Page MenuHomeFreeBSD

service/ipfw: Silence warning on restart
ClosedPublic

Authored by donner on May 2 2021, 8:51 PM.
Tags
None
Referenced Files
F80198917: D30083.id88531.diff
Fri, Mar 29, 4:15 AM
Unknown Object (File)
Wed, Mar 27, 3:16 AM
Unknown Object (File)
Feb 22 2024, 9:12 PM
Unknown Object (File)
Feb 7 2024, 1:00 PM
Unknown Object (File)
Jan 9 2024, 3:06 AM
Unknown Object (File)
Dec 22 2023, 11:00 PM
Unknown Object (File)
Dec 20 2023, 4:32 AM
Unknown Object (File)
Oct 21 2023, 3:06 PM

Details

Summary

Once the ipfw0 interface has been created, ifconfig(8) create will
throw a warning: ifconfig: create: bad value' when trying to create it
again.

PR: 241013
Submitted by: Jose Luis Duran
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

donner requested review of this revision.May 2 2021, 8:51 PM

The idea was to make it more in line with pflog's behavior, and of course to silence the warning. The patch is good as is for me, however.

Thank you for reviewing this.

donner added a subscriber: kp.

Add @kp for the pflog reference.

kp added inline comments.
libexec/rc/rc.d/ipfw
82

I think I wouldn't include this warning. After all, the system state is what we wanted it to be: we want ipfw0 to exist and it does.

This revision is now accepted and ready to land.May 3 2021, 9:40 AM
This revision was automatically updated to reflect the committed changes.
donner marked an inline comment as done.