Fix range descriptions in iovctl.conf(5) man page
ClosedPublic
Actions

Authored by pkelsey on Jul 3 2015, 9:41 PM.

Details

Reviewers

wblock
rstone

Group Reviewers

manpages

Commits

rS285189: Fix range upper bound for uint32_t and uint64_t, and reformat range

Summary

The uint32_t and uint64_t range descriptions were too large
by one on the upper end. The uint8_t, uint16_t, uint32_t, and
uint64_t range descriptions have been formatted to match those in the
pci_iov_schema(9) man page.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pkelsey updated this revision to Diff 6679.Jul 3 2015, 9:41 PM

pkelsey retitled this revision from to Fix range descriptions in iovctl.conf(5) man page.

pkelsey updated this object.

pkelsey added a reviewer: rstone.

Herald added a reviewer: manpages. · View Herald TranscriptJul 3 2015, 9:41 PM

Herald added a subscriber: imp. · View Herald Transcript

rstone accepted this revision.Jul 3 2015, 10:26 PM

rstone edited edge metadata.

This revision is now accepted and ready to land.Jul 3 2015, 10:26 PM

wblock added a subscriber: wblock.Jul 3 2015, 11:58 PM

wblock added inline comments.

usr.sbin/iovctl/iovctl.conf.5
111 ↗	(On Diff #6679)	This can be done with just Pq: .Pq 2**32 - 1 ,
115 ↗	(On Diff #6679)	.Pq 2**64 - 1 ,

pkelsey marked 2 inline comments as done.Jul 4 2015, 3:05 AM

pkelsey added inline comments.

usr.sbin/iovctl/iovctl.conf.5
111 ↗	(On Diff #6679)	Would you like me to change it for this patch? There is one other place in this man page where .Pq can be used instead of .Po Pc, and there are also several in the related man pages pci(9), pci_iov_schema(9), iovctl(8), which taken together significantly add to the few other uses of .Po Pc in the tree. What do you think if I leave this patch as focused on the range correction, and follow it with another patch that converts .Po Pc usage to .Pq in all of the related man pages I've mentioned here?

Value changes approved, either with .Pq included in this diff or in a separate patch. Please remember to update .Dd before commit and check the page with 'mandoc -Tlint' and 'igor -R'. Thanks!

usr.sbin/iovctl/iovctl.conf.5
111 ↗	(On Diff #6679)	If you want to fix the other pages, that would be very good. But you are not obligated to do that extra work, just changing the ones in this particular page is enough, either in this patch or a separate one.