Page MenuHomeFreeBSD

pf tests: IPv6 test case for the 'kill state(s)' feature
ClosedPublic

Authored by kp on Apr 16 2021, 5:52 PM.

Details

Summary

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp requested review of this revision.Apr 16 2021, 5:52 PM

According to https://www.iana.org/assignments/iana-ipv6-special-registry/iana-ipv6-special-registry.xhtml, the documentation prefix should never be assigned to any real interface. So please consider tto use 2001:2::/48 (benchmarking) instead. A real "Test-Prefix" is not assigned, yet.

According to https://www.iana.org/assignments/iana-ipv6-special-registry/iana-ipv6-special-registry.xhtml, the documentation prefix should never be assigned to any real interface. So please consider tto use 2001:2::/48 (benchmarking) instead. A real "Test-Prefix" is not assigned, yet.

We have standardised on 2001:db8 for our IPv6 test ranges (e.g. in tests/sys/netinet6/{forward6.sh,mkd.sh,ndp.sh}). If there were a dedicated testing prefix I'd suggest we should change them all in a separate commit, but I don't think the benchmarking prefix is sufficiently better to justify changing.

In D29797#669445, @kp wrote:

We have standardised on 2001:db8 for our IPv6 test ranges (e.g. in tests/sys/netinet6/{forward6.sh,mkd.sh,ndp.sh}). If there were a dedicated testing prefix I'd suggest we should change them all in a separate commit, but I don't think the benchmarking prefix is sufficiently better to justify changing.

That's fine.

This revision is now accepted and ready to land.Apr 19 2021, 4:02 PM