pf tests: IPv6 test case for the 'kill state(s)' feature
ClosedPublic
Actions

Authored by kp on Apr 16 2021, 5:52 PM.

Details

Reviewers

Group Reviewers

Commits

rGce5da7d24316: pf tests: IPv6 test case for the 'kill state(s)' feature
rG9af2317423f3: pf tests: IPv6 test case for the 'kill state(s)' feature

Summary

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Apr 16 2021, 5:52 PM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptApr 16 2021, 5:52 PM

kp requested review of this revision.Apr 16 2021, 5:52 PM

Harbormaster completed remote builds in B38628: Diff 87558.Apr 16 2021, 5:52 PM

According to https://www.iana.org/assignments/iana-ipv6-special-registry/iana-ipv6-special-registry.xhtml, the documentation prefix should never be assigned to any real interface. So please consider tto use 2001:2::/48 (benchmarking) instead. A real "Test-Prefix" is not assigned, yet.

In D29797#668976, @donner wrote:

According to https://www.iana.org/assignments/iana-ipv6-special-registry/iana-ipv6-special-registry.xhtml, the documentation prefix should never be assigned to any real interface. So please consider tto use 2001:2::/48 (benchmarking) instead. A real "Test-Prefix" is not assigned, yet.

We have standardised on 2001:db8 for our IPv6 test ranges (e.g. in tests/sys/netinet6/{forward6.sh,mkd.sh,ndp.sh}). If there were a dedicated testing prefix I'd suggest we should change them all in a separate commit, but I don't think the benchmarking prefix is sufficiently better to justify changing.

In D29797#669445, @kp wrote:

We have standardised on 2001:db8 for our IPv6 test ranges (e.g. in tests/sys/netinet6/{forward6.sh,mkd.sh,ndp.sh}). If there were a dedicated testing prefix I'd suggest we should change them all in a separate commit, but I don't think the benchmarking prefix is sufficiently better to justify changing.

That's fine.

This revision is now accepted and ready to land.Apr 19 2021, 4:02 PM

Closed by commit rG9af2317423f3: pf tests: IPv6 test case for the 'kill state(s)' feature (authored by kp). · Explain WhyApr 20 2021, 11:24 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG9af2317423f3: pf tests: IPv6 test case for the 'kill state(s)' feature.

kp added a commit: rGce5da7d24316: pf tests: IPv6 test case for the 'kill state(s)' feature.Apr 28 2021, 3:14 PM