Differential D29768

e1000: disable hw.em.sbp
ClosedPublic
Actions

Authored by kbowling on Apr 15 2021, 7:01 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 28, 8:56 AM

	Unknown Object (File)
	Fri, Mar 27, 5:48 AM

	Unknown Object (File)
	Thu, Mar 26, 7:38 AM

	Unknown Object (File)
	Thu, Mar 26, 12:33 AM

	Unknown Object (File)
	Tue, Mar 24, 9:00 AM

	Unknown Object (File)
	Sun, Mar 22, 6:05 PM

	Unknown Object (File)
	Sat, Mar 21, 2:25 PM

	Unknown Object (File)
	Sat, Mar 21, 11:57 AM

Subscribers

None

Details

Reviewers

markj
marius
erj

Group Reviewers

Intel Networking

Commits

rG94c02a765cb7: e1000: disable hw.em.sbp debug setting
rG135a6b5652f2: e1000: disable hw.em.sbp debug setting
rG548d8a131d53: e1000: disable hw.em.sbp debug setting

Summary

This is a debugging tunable that shouldn't have retained this setting after the initial iflib conversion of the driver

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248934
Reported by: Franco Fichtner <franco@opnsense.org>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kbowling requested review of this revision.Apr 15 2021, 7:01 AM

kbowling created this revision.

Seems reasonable to me.

This revision is now accepted and ready to land.Apr 15 2021, 1:55 PM

Closed by commit rG548d8a131d53: e1000: disable hw.em.sbp debug setting (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyApr 15 2021, 4:52 PM

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG548d8a131d53: e1000: disable hw.em.sbp debug setting.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG135a6b5652f2: e1000: disable hw.em.sbp debug setting.May 18 2021, 7:47 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG94c02a765cb7: e1000: disable hw.em.sbp debug setting.

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

2 lines

Diff 87496

sys/dev/e1000/if_em.c

Loading...