Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Nice! A few minor additional suggestions. Thanks!
| lib/libc/sys/ptrace.2 | ||
|---|---|---|
| 607 | Later sections say "the base", which is a little clearer, so do that here to be consistent: | |
| 627 | This line could be removed. It actually works either way on this one. | |
| 645 | "the argument" is not really needed and a bit redundant. It's not terrible, though. | |
| 654 | See note on line #646. | |
| 740 | Needs a "the": | |
| 753 | "cannot" is a little vague, can sometimes be read as permission rather than possibility. Probably better to use "will not": This error will not occur in 32-bit programs. | |
Handled the notes. One question is inline.
| lib/libc/sys/ptrace.2 | ||
|---|---|---|
| 627 | Do you mean, remove the article ? | |
| lib/libc/sys/ptrace.2 | ||
|---|---|---|
| 627 | Yes: (without markup) "The addr must point to..." is almost the same as "addr must point to..." In a programming context, it is the same. The special word "addr" will be highlighted by the markup, so adding an extra word just for capitalization at the start of the sentence is not necessary.* (*: I've been told it's Very Wrong to do this by one person, due to a naming practice from long ago that was created to fix a problem that no longer exists. I like to remove redundant words that do not make the sentence any clearer. And again, the original reason to always say "The blahblah argument" was so a script could parse it, which, as far as anyone can tell, is no longer done.) | |
Man page looks good. Please check with mandoc -Tlint and igor -R before commit. Thanks!