Page MenuHomeFreeBSD
Differential D29633

rtld: make dlerror() thread-local
ClosedPublic
Actions

Authored by kib on Apr 8 2021, 4:50 AM.

Details

Reviewers
emaste
arichardson
bdragon
Commits
rG4d9128da54f8: rtld: make dlerror() thread-local
rG08bfbd43594b: rtld: workaround for broken ABI
rG4d7f08c84bcf: rtld: unstaticise lockinfo and obj_from_addr()
Summary

PR: 95339

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib requested review of this revision.Apr 8 2021, 4:50 AM
kib created this revision.
arichardson added a comment.Apr 8 2021, 1:08 PM

Seems reasonable to me (unless we want to support TLS inside RTLD but that seems like it would require more work).

kib added a comment.Apr 8 2021, 9:26 PM
In D29633#664648, @arichardson wrote:

Seems reasonable to me (unless we want to support TLS inside RTLD but that seems like it would require more work).

It would be very inconvenient to use TLS in the source file that implements significant part of tooling for it.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2021, 2:35 PM
Closed by commit rG4d7f08c84bcf: rtld: unstaticise lockinfo and obj_from_addr() (authored by kib). · Explain Why
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG4d7f08c84bcf: rtld: unstaticise lockinfo and obj_from_addr().
kib added a commit: rG08bfbd43594b: rtld: workaround for broken ABI.
kib added a commit: rG4d9128da54f8: rtld: make dlerror() thread-local.

Revision Contents
Changeset List

PathSize
libexec/
rtld-elf/
1 line
3 lines
2 lines
2 lines

Diff 87223

View Options

libexec/rtld-elf/rtld.h

Loading...
View Options

libexec/rtld-elf/rtld.c

Loading...
View Options

libexec/rtld-elf/rtld_lock.h

Loading...
View Options

libexec/rtld-elf/rtld_lock.c

Loading...