Page MenuHomeFreeBSD

efivar: use bool for booleans
ClosedPublic

Authored by imp on Apr 7 2021, 5:59 AM.

Details

Summary

Rather than int flags we ++, use booleans for all command line args.
No functional change intended.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp requested review of this revision.Apr 7 2021, 5:59 AM
imp created this revision.
usr.sbin/efivar/efivar.c
388

I guess expressions like this might be why int was used? I think this should still work with bools though.

415

These are still using arithmetic expressions.

Address markj's comments. Cast the bools to ints to add them, though this 'works' today.

markj added inline comments.
usr.sbin/efivar/efivar.c
409
This revision is now accepted and ready to land.Apr 9 2021, 1:53 PM
This revision was automatically updated to reflect the committed changes.