Page MenuHomeFreeBSD
Differential D29621

efivar: use bool for booleans
ClosedPublic
Actions

Authored by imp on Apr 7 2021, 5:59 AM.
Tags
None
Referenced Files
F131786991: D29621.id86942.diff
Sat, Oct 11, 4:05 AM
Unknown Object (File)
Tue, Oct 7, 9:24 PM
Unknown Object (File)
Mon, Sep 22, 8:21 PM
Unknown Object (File)
Sat, Sep 20, 3:13 AM
Unknown Object (File)
Wed, Sep 17, 10:54 AM
Unknown Object (File)
Sep 10 2025, 7:12 AM
Unknown Object (File)
Sep 6 2025, 2:00 AM
Unknown Object (File)
Aug 27 2025, 12:17 AM
View All Files
Subscribers
None

Details

Reviewers
jhb
markj
Commits
rGd8d0ac7b5d73: efivar: use bool for booleans
rG066b096d13a1: efivar: use bool for booleans
Summary

Rather than int flags we ++, use booleans for all command line args.
No functional change intended.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38377
Build 35266: arc lint + arc unit

Event Timeline

imp requested review of this revision.Apr 7 2021, 5:59 AM
imp created this revision.
Harbormaster completed remote builds in B38377: Diff 86942.Apr 7 2021, 6:00 AM
imp added reviewers: jhb, markj.Apr 7 2021, 6:04 AM
markj added inline comments.Apr 7 2021, 1:25 PM
usr.sbin/efivar/efivar.c
387

I guess expressions like this might be why int was used? I think this should still work with bools though.

414

These are still using arithmetic expressions.

imp updated this revision to Diff 87089.Apr 8 2021, 10:18 PM

Address markj's comments. Cast the bools to ints to add them, though this 'works' today.

Harbormaster completed remote builds in B38441: Diff 87089.Apr 8 2021, 10:18 PM
markj accepted this revision.Apr 9 2021, 1:53 PM
markj added inline comments.
usr.sbin/efivar/efivar.c
408
This revision is now accepted and ready to land.Apr 9 2021, 1:53 PM
Closed by commit rG066b096d13a1: efivar: use bool for booleans (authored by imp). · Explain WhyApr 9 2021, 10:39 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG066b096d13a1: efivar: use bool for booleans.
vangyzen added a commit: rGd8d0ac7b5d73: efivar: use bool for booleans.Mar 2 2022, 10:01 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
efivar/
35 lines

Diff 86942

View Options

usr.sbin/efivar/efivar.c

Loading...