efivar: use bool for booleans
ClosedPublic
Actions

Authored by imp on Apr 7 2021, 5:59 AM.

Details

Reviewers

jhb
markj

Commits

rGd8d0ac7b5d73: efivar: use bool for booleans
rG066b096d13a1: efivar: use bool for booleans

Summary

Rather than int flags we ++, use booleans for all command line args.
No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Apr 7 2021, 5:59 AM

imp created this revision.

Harbormaster completed remote builds in B38377: Diff 86942.Apr 7 2021, 6:00 AM

imp added reviewers: jhb, markj.Apr 7 2021, 6:04 AM

markj added inline comments.Apr 7 2021, 1:25 PM

usr.sbin/efivar/efivar.c
388	I guess expressions like this might be why int was used? I think this should still work with bools though.
415	These are still using arithmetic expressions.

Address markj's comments. Cast the bools to ints to add them, though this 'works' today.

Harbormaster completed remote builds in B38441: Diff 87089.Apr 8 2021, 10:18 PM

markj accepted this revision.Apr 9 2021, 1:53 PM

markj added inline comments.

usr.sbin/efivar/efivar.c
409

This revision is now accepted and ready to land.Apr 9 2021, 1:53 PM

Closed by commit rG066b096d13a1: efivar: use bool for booleans (authored by imp). · Explain WhyApr 9 2021, 10:39 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG066b096d13a1: efivar: use bool for booleans.

vangyzen added a commit: rGd8d0ac7b5d73: efivar: use bool for booleans.Mar 2 2022, 10:01 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

efivar/

efivar.c

45 lines

Diff 87160

View Options

efivar: use bool for booleansClosedPublicActions