Page MenuHomeFreeBSD

makefs: Ignore the "tags" keyword
ClosedPublic

Authored by markj on Tue, Mar 23, 2:25 AM.

Details

Summary

We emit these when making a filesystem using the METALOG that comes with
a -DNO_ROOT build. I believe they're used exclusively for pkgbase,
though I can't quite see how.

When building a filesystem using such a METALOG, many warnings get
emitted. It seems to make sense to just ignore this keyword (beyond
checking that there's an associated value).

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj requested review of this revision.Tue, Mar 23, 2:25 AM
This revision is now accepted and ready to land.Tue, Mar 23, 2:26 AM

I don't see many reports of this on the mailing lists, so I might be doing something wrong. But I get tons of warnings with a simple

$ make installkernel -DNO_ROOT DESTDIR=/tmp
$ makefs ... /tmp/kernelfs.raw /tmp/METALOG

Seems sensible to me. I'm not entirely sure we shouldn't just silently ignore unknown tags unless some sort of --picky option is specified.

Seems sensible to me. I'm not entirely sure we shouldn't just silently ignore unknown tags unless some sort of --picky option is specified.

I thought about it but wanted to stay conservative for now. The set of tools in the base system that emit or consume mtrees is fairly small so it's easy to evaluate keywords on a case-by-case basis.