Page MenuHomeFreeBSD
Differential D29128

sed.1: provide more information on -I and -i
Needs RevisionPublic
Actions

Authored by emaste on Mar 8 2021, 2:14 PM.
Tags
None
Referenced Files
F165930616: D29128.id85329.diff
Mon, Aug 10, 2:19 PM
F165884528: D29128.diff
Mon, Aug 10, 10:19 AM
Unknown Object (File)
Sun, Aug 9, 9:51 AM
Unknown Object (File)
Sun, Aug 9, 9:51 AM
Unknown Object (File)
Sat, Aug 8, 4:56 PM
Unknown Object (File)
Wed, Jul 29, 12:39 PM
Unknown Object (File)
Tue, Jul 28, 2:14 AM
Unknown Object (File)
Mon, Jul 27, 4:14 PM
View All Files
Subscribers
0mp
gbe

Details

Reviewers
kevans
tobik
gbe
0mp
Group Reviewers
manpages
Summary

For compatibility with other versions of sed (GNU and other BSDs) there should be no space between -I or -i, and the backup extension. The extension is an optional argument with these other sed versions, and "-I .bak" is interpreted as a no-argument (no backup) -I flag, followed by an invalid command ".bak".

Clarify -I "" as a special case to specify no backup that is not compatible with other sed versions.

PR: 254091

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Mar 8 2021, 2:14 PM
emaste created this revision.
gbe accepted this revision.Mar 11 2021, 5:57 PM
gbe added a subscriber: gbe.

LGTM from manpages. Thanks for working on this PR.

This revision is now accepted and ready to land.Mar 11 2021, 5:57 PM
tobik accepted this revision.Mar 12 2021, 9:35 PM
0mp requested changes to this revision.Apr 18 2021, 1:55 PM
0mp added a subscriber: 0mp.
0mp added inline comments.
usr.bin/sed/sed.1
118

I think that we usually try to avoid "you" in docs.

124

This should probably be:

.Fl i Cm \&"" .

This way "" is stylized as a command modifier.

This revision now requires changes to proceed.Apr 18 2021, 1:55 PM

Revision Contents
Changeset List

PathSize
usr.bin/
sed/
43 lines

Diff 85329

View Options

usr.bin/sed/sed.1

Loading...