powerpc64le: port optimized strcpy for LE version of processor
ClosedPublic
Actions

Authored by bruno.larsen_eldorado.org.br on Mar 4 2021, 7:34 PM.

Details

Reviewers

leonardo.bianconi_eldorado.org.br
luporl
jhibbits
alfredo

Commits

rGe21b6ce854f2: [PowerPC64] Port optimized strcpy to PPC64LE
rG9f50aa45be18: [PowerPC64] Port optimized strcpy to PPC64LE

Summary

PPC64: added new path for strcpy when calling from little endian processor

Test Plan

stability of the system is enough to show that it has been fixed, and lffpires's funcperf shows the increase in speed (upwards of 6x in many cases)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bruno.larsen_eldorado.org.br created this revision.Mar 4 2021, 7:34 PM

Herald added subscribers: Contributor Reviews (base), imp. · View Herald TranscriptMar 4 2021, 7:34 PM

Harbormaster completed remote builds in B37585: Diff 85159.Mar 4 2021, 7:34 PM

bruno.larsen_eldorado.org.br requested review of this revision.Mar 4 2021, 7:34 PM

bruno.larsen_eldorado.org.br added a project: PowerPC.Mar 4 2021, 7:35 PM

Herald added subscribers: alfredo, luporl, bdragon. · View Herald TranscriptMar 4 2021, 7:35 PM

bruno.larsen_eldorado.org.br added reviewers: leonardo.bianconi_eldorado.org.br, fernando.valle_eldorado.org.br.Mar 4 2021, 7:39 PM

bruno.larsen_eldorado.org.br edited reviewers, added: luporl, jhibbits, alfredo; removed: fernando.valle_eldorado.org.br.Mar 4 2021, 7:48 PM

bruno.larsen_eldorado.org.br added a subscriber: fernando.valle_eldorado.org.br.

luporl added inline comments.Mar 8 2021, 6:00 PM

lib/libc/powerpc64/string/strcpy_arch_2_05.S
163	It's better to use srdi (lowercase)
196	s/Endianess/Endianness/

fixed formatting issues

Harbormaster completed remote builds in B37691: Diff 85384.Mar 9 2021, 11:43 AM

LGTM.

This revision is now accepted and ready to land.Mar 9 2021, 11:47 AM

Closed by commit rG9f50aa45be18: [PowerPC64] Port optimized strcpy to PPC64LE (authored by luporl). · Explain WhyMar 25 2021, 4:21 PM

This revision was automatically updated to reflect the committed changes.

luporl added a commit: rG9f50aa45be18: [PowerPC64] Port optimized strcpy to PPC64LE.

luporl added a commit: rGe21b6ce854f2: [PowerPC64] Port optimized strcpy to PPC64LE.Apr 6 2021, 11:28 AM

Revision Contents
Changeset List

Path

Size

lib/

libc/

powerpc64/

string/

Makefile.inc

7 lines

strcpy_arch_2_05.S

66 lines

Diff 86309

View Options

lib/libc/powerpc64/string/Makefile.inc