Page MenuHomeFreeBSD

xen: move x86-specific xen_vector_callback_enabled to sys/x86
ClosedPublic

Authored by ehem_freebsd_m5p.com on Mar 3 2021, 4:32 PM.
Tags
None
Referenced Files
F150212256: D29040.id85774.diff
Mon, Mar 30, 7:33 AM
Unknown Object (File)
Sat, Mar 28, 4:21 PM
Unknown Object (File)
Thu, Mar 26, 4:09 PM
Unknown Object (File)
Sat, Mar 21, 2:00 PM
Unknown Object (File)
Tue, Mar 17, 6:50 AM
Unknown Object (File)
Mon, Mar 9, 6:13 PM
Unknown Object (File)
Mon, Mar 9, 11:03 AM
Unknown Object (File)
Fri, Mar 6, 11:59 AM

Details

Summary

This appears x86-only and so should not be in the common area.

Adapted-to-HEAD-by: Elliott Mitchell <ehem+freebsd@m5p.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

LGTM, we should make this a bool type also.

This revision is now accepted and ready to land.Mar 4 2021, 9:05 AM

Also, the 'Adapted-to-HEAD-by' tag is not really a standard tag, and doesn't mention the original author either. I would just add a line saying:

"Based on the original work done by ..."

Also, the 'Adapted-to-HEAD-by' tag is not really a standard tag, and doesn't mention the original author either. I would just add a line saying:

"Based on the original work done by ..."

This is differing behavior between Phabricator and other source review tools (such as Gerrit). Tools which follow git more closely the "Author:" header is preserved, pointing at the original author and date; and the person doing the adapting gets their name out as "Committer" or an extra tag. I see strengths and weaknesses in both approaches, Phabricator supports more source control tools and thus cannot closely match a typical git workflow.

This will need adjustment for bunches of these patches. D29040-D29043 are Julien Grall commits. D28982 is purely my work which came up during the forward-port process.