Page MenuHomeFreeBSD

xen: move x86-specific xen_vector_callback_enabled to sys/x86
ClosedPublic

Authored by ehem_freebsd_m5p.com on Mar 3 2021, 4:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 8, 3:24 PM
Unknown Object (File)
Thu, Mar 6, 1:28 AM
Unknown Object (File)
Thu, Feb 27, 4:49 AM
Unknown Object (File)
Feb 20 2025, 6:59 AM
Unknown Object (File)
Feb 16 2025, 2:54 AM
Unknown Object (File)
Feb 5 2025, 3:36 PM
Unknown Object (File)
Feb 4 2025, 6:48 AM
Unknown Object (File)
Jan 17 2025, 1:01 PM

Details

Summary

This appears x86-only and so should not be in the common area.

Adapted-to-HEAD-by: Elliott Mitchell <ehem+freebsd@m5p.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

LGTM, we should make this a bool type also.

This revision is now accepted and ready to land.Mar 4 2021, 9:05 AM

Also, the 'Adapted-to-HEAD-by' tag is not really a standard tag, and doesn't mention the original author either. I would just add a line saying:

"Based on the original work done by ..."

Also, the 'Adapted-to-HEAD-by' tag is not really a standard tag, and doesn't mention the original author either. I would just add a line saying:

"Based on the original work done by ..."

This is differing behavior between Phabricator and other source review tools (such as Gerrit). Tools which follow git more closely the "Author:" header is preserved, pointing at the original author and date; and the person doing the adapting gets their name out as "Committer" or an extra tag. I see strengths and weaknesses in both approaches, Phabricator supports more source control tools and thus cannot closely match a typical git workflow.

This will need adjustment for bunches of these patches. D29040-D29043 are Julien Grall commits. D28982 is purely my work which came up during the forward-port process.