Page MenuHomeFreeBSD

xen/xenusb: always include xen/xen-os.h rather than machine/xen/xen-os.h
ClosedPublic

Authored by ehem_freebsd_m5p.com on Mar 3 2021, 4:35 PM.

Details

Summary

Fix compilation since machine/xen/xen-os.h is requiring definition
existing in xen/xen-os.h.

In general machine/xen/xen-os.h should never be included

Adapted-to-HEAD-by: Elliott Mitchell <ehem+freebsd@m5p.com>

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Mar 4 2021, 8:57 AM

This has the same issue of D29040, I had previously dealt with patch submission via mailing list and other review systems where the git author field was preserved, so crediting someone else you simply left them in the author field. Phabricator is the inverse where you need to add the original author as the footer, and the person submitting it for review gets the author field.

One issue, what are the conventional footer names? This particular one, this is simply a forward port where it is 99% the original author (simply a forward rebase). Some of this series needed rather substantial rework by me before submission (and perhaps only 75% original author's work). There are a few which were merely inspired by the original author.

I also wonder if there should be a "Group"/"Project"/"Umbrella" for Xen.