Page MenuHomeFreeBSD
Differential D29016

capsicum-test: Update for O_BENEATH removal
ClosedPublic
Actions

Authored by arichardson on Mar 2 2021, 6:26 PM.
Tags
None
Referenced Files
F167421722: D29016.id85645.diff
Fri, Aug 21, 3:48 PM
Unknown Object (File)
Thu, Aug 20, 6:06 PM
Unknown Object (File)
Thu, Aug 20, 9:15 AM
Unknown Object (File)
Wed, Aug 19, 1:23 AM
Unknown Object (File)
Tue, Aug 18, 8:10 PM
Unknown Object (File)
Wed, Aug 12, 9:27 PM
Unknown Object (File)
Sun, Aug 9, 11:45 AM
Unknown Object (File)
Sun, Aug 9, 11:44 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
emaste
lwhsu
markj
Group Reviewers
capsicum
Commits
rGc4a6d3b183af: capsicum-test: Update for O_BENEATH removal
rG8cf5812af4b7: capsicum-test: Update for O_BENEATH removal
Summary

Update the tests to check O_RESOLVE_BENEATH instead.
If this looks reasonable, I'll try to upstream this change.
This keeps a compat fallback for O_BENEATH since the Linux port still
has/had O_BENEATH with "no .., no absolute paths" semantics.

Test Plan

/usr/tests/sys/capsicum/capsicum-test -u 977 passes and runs the O_RESOLVE_BENEATH tests.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson created this revision.Mar 2 2021, 6:26 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 2 2021, 6:26 PM
arichardson requested review of this revision.Mar 2 2021, 6:26 PM
Harbormaster completed remote builds in B37507: Diff 84985.Mar 2 2021, 6:27 PM
markj accepted this revision.Mar 2 2021, 6:29 PM
This revision is now accepted and ready to land.Mar 2 2021, 6:29 PM
kib added inline comments.Mar 2 2021, 6:53 PM
contrib/capsicum-test/openat.cc
357

This is weird, because if you redefine O_RESOLVE_BENEATH as O_BENEATH, this could succeed (depending on the cwd).

arichardson added inline comments.Mar 4 2021, 10:48 AM
contrib/capsicum-test/openat.cc
357

I think there could be other interesting errors if cwd == /. I guess the testsuite should check that the cwd is not inside / or /etc.

Closed by commit rG8cf5812af4b7: capsicum-test: Update for O_BENEATH removal (authored by arichardson). · Explain WhyMar 12 2021, 5:36 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG8cf5812af4b7: capsicum-test: Update for O_BENEATH removal.
arichardson added a commit: rGc4a6d3b183af: capsicum-test: Update for O_BENEATH removal.Mar 17 2021, 10:24 PM

Revision Contents
Changeset List

PathSize
contrib/
capsicum-test/
22 lines

Diff 85645

View Options

contrib/capsicum-test/openat.cc

Loading...