Page MenuHomeFreeBSD

capsicum-test: Update for O_BENEATH removal
ClosedPublic

Authored by arichardson on Mar 2 2021, 6:26 PM.

Details

Summary

Update the tests to check O_RESOLVE_BENEATH instead.
If this looks reasonable, I'll try to upstream this change.
This keeps a compat fallback for O_BENEATH since the Linux port still
has/had O_BENEATH with "no .., no absolute paths" semantics.

Test Plan

/usr/tests/sys/capsicum/capsicum-test -u 977 passes and runs the O_RESOLVE_BENEATH tests.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Mar 2 2021, 6:29 PM
contrib/capsicum-test/openat.cc
356

This is weird, because if you redefine O_RESOLVE_BENEATH as O_BENEATH, this could succeed (depending on the cwd).

contrib/capsicum-test/openat.cc
356

I think there could be other interesting errors if cwd == /. I guess the testsuite should check that the cwd is not inside / or /etc.