Page MenuHomeFreeBSD

wg: Fix some mbuf leaks in the input path
ClosedPublic

Authored by markj on Mar 2 2021, 3:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 12:27 PM
Unknown Object (File)
Sun, Jan 26, 8:17 PM
Unknown Object (File)
Dec 31 2024, 2:53 PM
Unknown Object (File)
Dec 28 2024, 1:24 AM
Unknown Object (File)
Dec 6 2024, 12:50 AM
Unknown Object (File)
Nov 12 2024, 6:34 AM
Unknown Object (File)
Oct 30 2024, 11:08 AM
Unknown Object (File)
Oct 27 2024, 4:14 PM
Subscribers

Details

Summary
  • When m_defrag() fails we have to free the mbuf ourselves.
  • If the handshake input queue is full, we are responsible for dropping the packet.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37501
Build 34390: arc lint + arc unit

Event Timeline

markj requested review of this revision.Mar 2 2021, 3:11 PM
sys/dev/if_wg/module/if_wg_session.c
1939

How is this queue locked?

afedorov added inline comments.
sys/dev/if_wg/module/if_wg_session.c
1908

Hmm, is m_defrag() really needed here? This is a very costly operation due to allocation. Because we only need to get "pkttype", maybe using m_pullup is enough?

sys/dev/if_wg/module/if_wg_session.c
1908

That's a good question. wg_handshake() assumes that the entire packet is contiguous, though, so a pullup to get the packet type is not sufficient.

This revision is now accepted and ready to land.Mar 8 2021, 6:45 AM