Page MenuHomeFreeBSD
Differential D28736

DO NOT MERGE: This seems to fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253589
AbandonedPublic
Actions

Authored by arichardson on Feb 17 2021, 7:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 6:49 PM
Unknown Object (File)
Fri, Apr 19, 5:04 PM
Unknown Object (File)
Dec 20 2023, 6:11 AM
Unknown Object (File)
Dec 13 2023, 8:35 AM
Unknown Object (File)
Jun 23 2023, 11:46 PM
Unknown Object (File)
May 14 2023, 7:03 PM
Unknown Object (File)
May 3 2023, 10:24 PM
Unknown Object (File)
Apr 26 2023, 4:05 AM
View All 13 Files
Subscribers
glebius
imp
melifaro
rrs

Details

Reviewers
rrs
Group Reviewers
transport
Summary

I haven't seen the CSan warnings since applying this patch, before it would give me a warning anytime I read a file from smbfs.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37165
Build 34054: arc lint + arc unit

Event Timeline

arichardson created this revision.Feb 17 2021, 7:41 PM
Herald added a reviewer: transport. · View Herald TranscriptFeb 17 2021, 7:41 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
arichardson requested review of this revision.Feb 17 2021, 7:41 PM
Harbormaster completed remote builds in B37107: Diff 84124.Feb 17 2021, 7:41 PM
rrs requested changes to this revision.Feb 18 2021, 3:58 PM
rrs added a subscriber: rrs.

This will cause a HUGE performance impact! sbspace() is called often and
twiddling the extra locks is not useful. You are just looking (reading) two
variables or even one variable in the sbused case. You do not need a lock for this!

This revision now requires changes to proceed.Feb 18 2021, 3:58 PM
arichardson added a comment.Feb 18 2021, 5:44 PM

As you can see from the title of this diff I do not intend to merge this. It is just a debugging patch to find potentially racy accesses.

arichardson updated this revision to Diff 84219.Feb 18 2021, 5:59 PM

update to latest WIP. This is purely for debugging, not intended to be merged (possibly with the exception of using atomic_load)

Harbormaster completed remote builds in B37165: Diff 84219.Feb 18 2021, 6:00 PM
arichardson abandoned this revision.Jan 4 2023, 9:09 AM
Herald added a subscriber: glebius. · View Herald TranscriptJan 4 2023, 9:09 AM

Revision Contents
Changeset List

PathSize
sys/
amd64/
conf/
6 lines
5 lines
kern/
2 lines
8 lines
netinet/
12 lines
10 lines
2 lines
sys/
18 lines

Diff 84219

View Options

sys/amd64/conf/GENERIC

Loading...
View Options

sys/amd64/conf/GENERIC-KCSAN

Loading...
View Options

sys/kern/sys_socket.c

Loading...
View Options

sys/kern/uipc_sockbuf.c

Loading...
View Options

sys/netinet/tcp_input.c

Loading...
View Options

sys/netinet/tcp_output.c

Loading...
View Options

sys/netinet/tcp_timewait.c

Loading...
View Options

sys/sys/sockbuf.h

Loading...