Page MenuHomeFreeBSD

libc: Fix t_spawn_fileactions test after ATF update
ClosedPublic

Authored by arichardson on Feb 15 2021, 11:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 3:12 AM
Unknown Object (File)
Wed, Oct 23, 8:06 AM
Unknown Object (File)
Oct 21 2024, 1:11 AM
Unknown Object (File)
Sep 30 2024, 11:31 PM
Unknown Object (File)
Sep 21 2024, 5:17 AM
Unknown Object (File)
Sep 21 2024, 2:25 AM
Unknown Object (File)
Sep 19 2024, 9:38 PM
Unknown Object (File)
Sep 15 2024, 8:07 PM
Subscribers

Details

Summary

Since https://github.com/freebsd/atf/commit/4581cefc1e3811dd3c926b5dd4b15fd63d2e19da
ATF opens the results file on startup. This fixes problems like
capsicumized tests not being able to open the file on exit.

However, this test closes all file descriptors above 3 to get a
deterministic fd table allocation for the child. Instead of using closefrom
(which will close the ATF output file FD) I've changed this test use
the lowest available fd and pass that to the helper program as a string.

We could also try to re-open the results file in ATF if we get a EBADF
error, but that will fail when running under Capsicum.

Test Plan

test passes now.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable