Page MenuHomeFreeBSD

devel/rlwrap: Update to 0.44
ClosedPublic

Authored by otis on Jan 30 2021, 4:27 PM.

Details

Summary
  • Update to 0.44
  • Reformat Makefile according to portclippy/portfmt
  • Fix pkg-plist

PR: 253101
Reported by: otis
Submitted by: otis

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

otis requested review of this revision.Jan 30 2021, 4:27 PM

Juraj, is there any specific reason to use the MASTER_SITES in this case when software distributed from GitHub?

otis edited the summary of this revision. (Show Details)

Update MASTER_SITES after upstream renamed release tag to proper value.

If there was no official release, then GH_ variables should be used to fetch from the specific tag. But as the official release is available, the preferred method is to download the released tarball.

I've just tried to build the port with the following patch for the original Makefile and everything works fine.

I'd prefer to use GH_TAGNAME instead of switching to MASTER_SITES.

In D28429#636097, @osa wrote:

I've just tried to build the port with the following patch for the original Makefile and everything works fine.

I'd prefer to use GH_TAGNAME instead of switching to MASTER_SITES.

Somewhere in the Porters Handbook that I can't find right now, it says use the release file if possible. This avoids issues if GitHub re-generates the tarball, which happens sometimes even if there is no release or change in the repo, etc. ie, GitHub has some operational issue and the file is regenerated.

The WWW link in the pkg-descr seems to no longer work, please update that. Also, no need to specify reported by/submitted by, that's assumed to be the committer if not specified.

This revision is now accepted and ready to land.Feb 11 2021, 2:03 PM
This revision was automatically updated to reflect the committed changes.