Page MenuHomeFreeBSD

[porters-handbook]: Clarify prefixes in patch file names
ClosedPublic

Authored by fernape on Jan 21 2021, 11:10 AM.
Tags
None
Referenced Files
F103899104: D28268.diff
Sat, Nov 30, 10:24 PM
Unknown Object (File)
Tue, Nov 19, 5:25 PM
Unknown Object (File)
Tue, Nov 19, 2:48 PM
Unknown Object (File)
Tue, Nov 19, 3:25 AM
Unknown Object (File)
Mon, Nov 18, 10:47 PM
Unknown Object (File)
Mon, Nov 18, 9:24 PM
Unknown Object (File)
Tue, Nov 12, 1:37 PM
Unknown Object (File)
Mon, Nov 4, 1:50 PM

Details

Summary

Patches must start with patch- in order to be applied automatically.
Conditional patches must not start with patch-.

PR: 249038
Reported by: pauamma@gundo.com

Test Plan
  • igor clean
  • page renders properly

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp requested changes to this revision.Apr 18 2021, 1:48 PM

Otherwise, it's a good change!

documentation/content/en/books/porters-handbook/slow-porting/chapter.adoc
215 ↗(On Diff #82979)

Also, maybe start the sentence on a new line? I'm not sure what the style guide is at the moment.

216 ↗(On Diff #82979)
217 ↗(On Diff #82979)

We usually try to avoid "you" in documentation.

This revision now requires changes to proceed.Apr 18 2021, 1:48 PM

Address suggestions by 0mp:

Note that all the previous changes have gone away in Phabricator because the file name changed from _chapter.adoc to _index.adoc which is what we always use from now on.

Almost there!

documentation/content/en/books/porters-handbook/slow-porting/_index.adoc
214

Suggestion: maybe we can simplify this sentence further like this.

  • Simplify sentence

    Suggested by 0mp. Use present tense.
fernape added inline comments.
documentation/content/en/books/porters-handbook/slow-porting/_index.adoc
214

Easier to read. Thanks!

Thanks! Let's get it into the tree!

This revision was not accepted when it landed; it landed in state Needs Review.Apr 20 2021, 9:47 AM
This revision was automatically updated to reflect the committed changes.
fernape marked an inline comment as done.