Page MenuHomeFreeBSD
Differential D28256

ZFS: fix assertions with INVARIANTS
ClosedPublic
Actions

Authored by asomers on Jan 20 2021, 3:56 PM.
Tags
None
Referenced Files
F82099615: D28256.id.diff
Thu, Apr 25, 12:32 PM
Unknown Object (File)
Thu, Apr 25, 1:50 AM
Unknown Object (File)
Feb 24 2024, 7:44 PM
Unknown Object (File)
Feb 18 2024, 6:53 AM
Unknown Object (File)
Feb 12 2024, 7:16 AM
Unknown Object (File)
Jan 4 2024, 7:27 AM
Unknown Object (File)
Dec 20 2023, 7:10 AM
Unknown Object (File)
Oct 7 2023, 10:20 PM
View All 18 Files
Subscribers
delphij
imp

Details

Reviewers
mmacy
freqlabs
Commits
rG8874f305d814: ZFS: fix assertions with INVARIANTS
rG174a7e578a33: ZFS: fix assertions with INVARIANTS
Summary

AFAICT, this was an oversight from
9e5787d2284e187abb5b654d924394a65772e004 (svn r364746). That revision
inadvertently disabled assertions unconditionally.

Sponsored by: Axcient

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36370
Build 33259: arc lint + arc unit

Event Timeline

asomers created this revision.Jan 20 2021, 3:56 PM
Herald added subscribers: delphij, imp. · View Herald TranscriptJan 20 2021, 3:56 PM
Harbormaster completed remote builds in B36370: Diff 82638.Jan 20 2021, 3:56 PM
asomers requested review of this revision.Jan 20 2021, 3:56 PM
asomers added a reviewer: freqlabs.Feb 3 2021, 7:46 PM

ping. Is anybody able to review this change?

freqlabs added a comment.Feb 4 2021, 1:02 AM

The asserts are working fine when building OpenZFS out of tree, so how is it that this is needed in tree?

I am concerned that this Makefile is not well maintained. It is essentially a copy of sys/contrib/openzfs/module/Makefile.bsd and I'd imagine with a little attention it could be trimmed down to a few lines and an include for that file.

asomers added a comment.Feb 4 2021, 2:02 AM
In D28256#637259, @freqlabs wrote:

The asserts are working fine when building OpenZFS out of tree, so how is it that this is needed in tree?

I am concerned that this Makefile is not well maintained. It is essentially a copy of sys/contrib/openzfs/module/Makefile.bsd and I'd imagine with a little attention it could be trimmed down to a few lines and an include for that file.

I've never tried building OpenZFS out-of-tree. For in-tree builds, nothing defines DEBUG if you don't include this file. It probably works for the out-of-tree build because if the stanza that begins

.if defined(WITH_DEBUG) && ${WITH_DEBUG} == "true"
CFLAGS+= -DZFS_DEBUG -g

which only appears in sys/contrib/openzfs/module/Makefile.bsd .

freqlabs accepted this revision.Feb 8 2021, 4:24 PM
This revision is now accepted and ready to land.Feb 8 2021, 4:24 PM
Closed by commit rG174a7e578a33: ZFS: fix assertions with INVARIANTS (authored by asomers). · Explain WhyFeb 8 2021, 11:43 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rG174a7e578a33: ZFS: fix assertions with INVARIANTS.
asomers added a commit: rG8874f305d814: ZFS: fix assertions with INVARIANTS.Feb 13 2021, 5:04 AM

Revision Contents
Changeset List

PathSize
sys/
modules/
zfs/
2 lines

Diff 82638

View Options

sys/modules/zfs/Makefile

Loading...