Convert unmapped mbufs before computing checksums in IPsec.
ClosedPublic
Actions

Authored by jhb on Jan 15 2021, 10:57 PM.

Details

Reviewers

gallatin
np

Commits

rG8e9313caa672: Convert unmapped mbufs before computing checksums in IPsec.

Summary

This is similar to the logic used in ip_output() to convert mbufs
prior to computing checksums. Unmapped mbufs can be sent when using
sendfile() over IPsec or using KTLS over IPsec.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 15 2021, 10:57 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptJan 15 2021, 10:57 PM

jhb requested review of this revision.Jan 15 2021, 10:57 PM

Harbormaster completed remote builds in B36250: Diff 82347.Jan 15 2021, 10:57 PM

Chelsio QA managed to dream up trying this combination (KTLS over IPsec) which led to panics when computing checksums.

It seems part of this is already in D28160

ae mentioned this in D28160: netipsec: Fix handling of unmapped mbufs.Jan 16 2021, 11:54 AM

np accepted this revision.Jan 18 2021, 7:16 AM

This revision is now accepted and ready to land.Jan 18 2021, 7:16 AM

Closed by commit rG8e9313caa672: Convert unmapped mbufs before computing checksums in IPsec. (authored by jhb). · Explain WhyJan 19 2021, 7:57 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG8e9313caa672: Convert unmapped mbufs before computing checksums in IPsec..

Revision Contents
Changeset List

Path

Size

sys/

netipsec/

ipsec_output.c

29 lines

Diff 82580

View Options

sys/netipsec/ipsec_output.c

Convert unmapped mbufs before computing checksums in IPsec.ClosedPublicActions