Page MenuHomeFreeBSD
Differential D28098

arm64: Don't disable options GDB in LINT.
ClosedPublic
Actions

Authored by jhb on Jan 11 2021, 7:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 13, 8:59 AM
Unknown Object (File)
Tue, Aug 11, 9:22 AM
Unknown Object (File)
Tue, Aug 11, 9:19 AM
Unknown Object (File)
Tue, Aug 11, 8:34 AM
Unknown Object (File)
Fri, Aug 7, 2:59 PM
Unknown Object (File)
Fri, Aug 7, 1:39 AM
Unknown Object (File)
Thu, Aug 6, 2:25 PM
Unknown Object (File)
Thu, Aug 6, 7:25 AM
View All Files
Subscribers
andrew
emaste
imp

Details

Reviewers
mhorne
manu
Commits
rG36a2f5b81743: arm64: Don't disable options GDB in LINT.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Jan 11 2021, 7:58 PM
Herald added a reviewer: manu. · View Herald TranscriptJan 11 2021, 7:58 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
jhb requested review of this revision.Jan 11 2021, 7:58 PM
Harbormaster completed remote builds in B36113: Diff 82091.Jan 11 2021, 7:58 PM
mhorne requested changes to this revision.Jan 11 2021, 8:01 PM

I see options GDB in the common NOTES already.

This revision now requires changes to proceed.Jan 11 2021, 8:01 PM
jhb added a comment.Jan 11 2021, 10:09 PM

Oh, then instead I need to axe the line.

jhb retitled this revision from arm64: Enable options GDB in LINT. to arm64: Don't disable options GDB in LINT..Jan 11 2021, 10:09 PM
jhb updated this revision to Diff 82111.Jan 11 2021, 10:10 PM
  • Remove the nooptions instead.
Harbormaster completed remote builds in B36122: Diff 82111.Jan 11 2021, 10:10 PM
mhorne accepted this revision.Jan 11 2021, 10:12 PM

Thanks for catching this!

This revision is now accepted and ready to land.Jan 11 2021, 10:12 PM
Closed by commit rG36a2f5b81743: arm64: Don't disable options GDB in LINT. (authored by jhb). · Explain WhyJan 11 2021, 10:29 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG36a2f5b81743: arm64: Don't disable options GDB in LINT..

Revision Contents
Changeset List

PathSize
sys/
arm64/
conf/
2 lines

Diff 82112

View Options

sys/arm64/conf/NOTES

Loading...