Page MenuHomeFreeBSD

efidev: remove EFIIOC_GET_TABLE ioctl
ClosedPublic

Authored by kevans on Jan 7 2021, 9:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 13, 3:28 AM
Unknown Object (File)
Sat, Nov 8, 7:17 PM
Unknown Object (File)
Sat, Nov 8, 2:26 PM
Unknown Object (File)
Mon, Nov 3, 12:54 PM
Unknown Object (File)
Mon, Nov 3, 12:54 PM
Unknown Object (File)
Mon, Nov 3, 12:53 PM
Unknown Object (File)
Mon, Nov 3, 12:52 PM
Unknown Object (File)
Sat, Nov 1, 5:12 AM
Subscribers
None

Details

Summary

This ioctl would instantly induce a panic, likely since near inception, up
until 0861c7d3e048. Lack of previous interest in fixing it combined with
the problematic interface (exports a pointer, really a physical address)
brings us to the natural conclusion: remove it until a useful consumer
forward.

If it eventually gets resurrected, the interface should definitely not
return in this exact form and likely needs to be reimagined.

The associated KPI, efi_get_table, is left intact for the time being.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans requested review of this revision.Jan 7 2021, 9:57 PM
kevans created this revision.
This revision is now accepted and ready to land.Jan 7 2021, 10:11 PM
This revision was automatically updated to reflect the committed changes.