Page MenuHomeFreeBSD

efidev: remove EFIIOC_GET_TABLE ioctl
ClosedPublic

Authored by kevans on Jan 7 2021, 9:57 PM.
Tags
None
Referenced Files
F112306531: D28030.id81838.diff
Sat, Mar 15, 7:50 PM
F112306503: D28030.id81891.diff
Sat, Mar 15, 7:50 PM
Unknown Object (File)
Sun, Mar 9, 11:15 PM
Unknown Object (File)
Wed, Mar 5, 2:18 AM
Unknown Object (File)
Mon, Feb 24, 4:33 PM
Unknown Object (File)
Feb 4 2025, 11:51 AM
Unknown Object (File)
Jan 27 2025, 12:52 PM
Unknown Object (File)
Jan 26 2025, 9:41 PM
Subscribers
None

Details

Summary

This ioctl would instantly induce a panic, likely since near inception, up
until 0861c7d3e048. Lack of previous interest in fixing it combined with
the problematic interface (exports a pointer, really a physical address)
brings us to the natural conclusion: remove it until a useful consumer
forward.

If it eventually gets resurrected, the interface should definitely not
return in this exact form and likely needs to be reimagined.

The associated KPI, efi_get_table, is left intact for the time being.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans requested review of this revision.Jan 7 2021, 9:57 PM
kevans created this revision.
This revision is now accepted and ready to land.Jan 7 2021, 10:11 PM
This revision was automatically updated to reflect the committed changes.