Page MenuHomeFreeBSD

Prefer the use of vm_page_domain() to vm_phys_domain()
ClosedPublic

Authored by alc on Jan 6 2021, 7:10 PM.
Tags
None
Referenced Files
F132633083: D28005.id81765.diff
Sat, Oct 18, 2:54 PM
F132633080: D28005.id82038.diff
Sat, Oct 18, 2:54 PM
F132579990: D28005.id.diff
Sat, Oct 18, 3:40 AM
Unknown Object (File)
Fri, Oct 17, 5:18 PM
Unknown Object (File)
Thu, Oct 2, 5:28 AM
Unknown Object (File)
Sep 6 2025, 10:37 PM
Unknown Object (File)
Aug 29 2025, 5:12 PM
Unknown Object (File)
Aug 6 2025, 8:57 PM
Subscribers
None

Details

Summary

When we already have the vm page in hand, use vm_page_domain() instead of vm_phys_domain(). The former has a trivial constant-time implementation whereas the latter iterates over the mem_affinity array. Since both implementations are inlined, this change to just two call sites reduces the code size on amd64 by 320 bytes.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alc requested review of this revision.Jan 6 2021, 7:10 PM
alc created this revision.

As a note, this code goes with pv_locks patch (AFAIR).

This revision is now accepted and ready to land.Jan 6 2021, 7:15 PM