Page MenuHomeFreeBSD

du: tests: make H_flag tests more strict about output requirements
ClosedPublic

Authored by kevans on Jan 5 2021, 10:13 PM.

Details

Summary

The current version of this test will effectively pass as long as one of the
specified paths is in the output, and it could even be a subset of one of
the paths.

Strengthen up the test a little bit:

  • Specify beginning/end anchors for each path
  • Add egrep -v checks to make sure we don't have any *additional* paths
  • Ratchet down paths2 to exactly the two paths we expect to appear

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Macro stlgtm:

usr.bin/du/tests/du_test.sh
56

Could you please add a comment here noting why this check exists?

62

Could you please add a comment here noting why this check exists?

This revision is now accepted and ready to land.Jan 6 2021, 5:08 PM