du: tests: make H_flag tests more strict about output requirements
ClosedPublic
Actions

Authored by kevans on Jan 5 2021, 10:13 PM.

Details

Reviewers

ngie
emaste

Commits

rG3c5c39c7ad8f: du: tests: make H_flag tests more strict about output requirements

Summary

The current version of this test will effectively pass as long as one of the
specified paths is in the output, and it could even be a subset of one of
the paths.

Strengthen up the test a little bit:

Specify beginning/end anchors for each path
Add egrep -v checks to make sure we don't have any *additional* paths
Ratchet down paths2 to exactly the two paths we expect to appear

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Jan 5 2021, 10:13 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 5 2021, 10:13 PM

kevans requested review of this revision.Jan 5 2021, 10:13 PM

Harbormaster completed remote builds in B35959: Diff 81705.Jan 5 2021, 10:13 PM

kevans added a parent revision: D27983: du: tests: fix the H_flag test (primarily grep usage).Jan 5 2021, 10:13 PM

Macro stlgtm:

usr.bin/du/tests/du_test.sh
57	Could you please add a comment here noting why this check exists?
63	Could you please add a comment here noting why this check exists?

This revision is now accepted and ready to land.Jan 6 2021, 5:08 PM

Closed by commit rG3c5c39c7ad8f: du: tests: make H_flag tests more strict about output requirements (authored by kevans). · Explain WhyJan 7 2021, 10:38 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG3c5c39c7ad8f: du: tests: make H_flag tests more strict about output requirements.

Revision Contents
Changeset List

Path

Size

usr.bin/

du/

tests/

du_test.sh

16 lines

Diff 81841

View Options

usr.bin/du/tests/du_test.sh

du: tests: make H_flag tests more strict about output requirementsClosedPublicActions