Page MenuHomeFreeBSD

mpr, mps: Fix a stack buffer overflow in the user passthru ioctl
ClosedPublic

Authored by markj on Jan 4 2021, 11:37 PM.
Tags
None
Referenced Files
F174111351: D27963.diff
Wed, Sep 30, 5:12 PM
Unknown Object (File)
Tue, Sep 29, 8:39 PM
Unknown Object (File)
Wed, Sep 23, 3:30 AM
Unknown Object (File)
Wed, Sep 23, 3:28 AM
Unknown Object (File)
Wed, Sep 23, 3:15 AM
Unknown Object (File)
Sun, Sep 20, 10:10 AM
Unknown Object (File)
Wed, Sep 9, 2:19 AM
Unknown Object (File)
Sat, Sep 5, 11:41 AM
Subscribers

Details

Summary

Previously we copied in the request into a stack-allocated structure
that could be smaller than the request size. Furthermore, we checked
the request size only after doing the copyin.

Fix this by allocating a buffer to hold the request, then copying the
buffer's contents into a command descriptor. This is a bit heavy-handed
but I expect the overhead will not be noticeable. The approach of
coping the header in first is susceptible to TOCTOU problems.

Test Plan

I don't have any hardware driven by mpr or mps. Would anyone be willing
to test?

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable