Page MenuHomeFreeBSD

mpr, mps: Fix a stack buffer overflow in the user passthru ioctl
ClosedPublic

Authored by markj on Jan 4 2021, 11:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 20, 1:42 AM
Unknown Object (File)
Thu, Aug 20, 1:25 AM
Unknown Object (File)
Thu, Aug 13, 3:35 PM
Unknown Object (File)
Mon, Aug 10, 5:17 PM
Unknown Object (File)
Sun, Aug 9, 9:58 AM
Unknown Object (File)
Sun, Aug 9, 9:35 AM
Unknown Object (File)
Sun, Aug 9, 9:33 AM
Unknown Object (File)
Wed, Jul 22, 4:28 PM
Subscribers

Details

Summary

Previously we copied in the request into a stack-allocated structure
that could be smaller than the request size. Furthermore, we checked
the request size only after doing the copyin.

Fix this by allocating a buffer to hold the request, then copying the
buffer's contents into a command descriptor. This is a bit heavy-handed
but I expect the overhead will not be noticeable. The approach of
coping the header in first is susceptible to TOCTOU problems.

Test Plan

I don't have any hardware driven by mpr or mps. Would anyone be willing
to test?

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable