Page MenuHomeFreeBSD

mpr, mps: Fix a stack buffer overflow in the user passthru ioctl
ClosedPublic

Authored by markj on Jan 4 2021, 11:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 23, 7:42 AM
Unknown Object (File)
Sat, Mar 21, 2:14 PM
Unknown Object (File)
Thu, Mar 19, 7:44 AM
Unknown Object (File)
Wed, Mar 18, 11:50 PM
Unknown Object (File)
Thu, Mar 12, 12:37 PM
Unknown Object (File)
Feb 15 2026, 3:49 AM
Unknown Object (File)
Feb 13 2026, 6:59 AM
Unknown Object (File)
Feb 13 2026, 2:43 AM
Subscribers

Details

Summary

Previously we copied in the request into a stack-allocated structure
that could be smaller than the request size. Furthermore, we checked
the request size only after doing the copyin.

Fix this by allocating a buffer to hold the request, then copying the
buffer's contents into a command descriptor. This is a bit heavy-handed
but I expect the overhead will not be noticeable. The approach of
coping the header in first is susceptible to TOCTOU problems.

Test Plan

I don't have any hardware driven by mpr or mps. Would anyone be willing
to test?

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable