Page MenuHomeFreeBSD

mpr, mps: Fix a stack buffer overflow in the user passthru ioctl
ClosedPublic

Authored by markj on Jan 4 2021, 11:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 23, 11:03 PM
Unknown Object (File)
Mon, Jun 16, 6:16 AM
Unknown Object (File)
Fri, Jun 13, 3:16 PM
Unknown Object (File)
Wed, Jun 11, 7:50 AM
Unknown Object (File)
Tue, Jun 10, 12:50 PM
Unknown Object (File)
Thu, Jun 5, 9:47 PM
Unknown Object (File)
May 17 2025, 1:01 PM
Unknown Object (File)
May 15 2025, 6:49 PM
Subscribers

Details

Summary

Previously we copied in the request into a stack-allocated structure
that could be smaller than the request size. Furthermore, we checked
the request size only after doing the copyin.

Fix this by allocating a buffer to hold the request, then copying the
buffer's contents into a command descriptor. This is a bit heavy-handed
but I expect the overhead will not be noticeable. The approach of
coping the header in first is susceptible to TOCTOU problems.

Test Plan

I don't have any hardware driven by mpr or mps. Would anyone be willing
to test?

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable