Page MenuHomeFreeBSD
Differential D27863

Move Mk/bsd.ruby.mk to Mk/Uses/ruby.mk.
AbandonedPublic
Actions

Authored by yasu on Dec 31 2020, 8:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 29, 7:01 AM
Unknown Object (File)
Mon, Nov 25, 7:20 AM
Unknown Object (File)
Fri, Nov 22, 4:20 PM
Unknown Object (File)
Tue, Nov 19, 9:37 AM
Unknown Object (File)
Mon, Nov 18, 3:59 AM
Unknown Object (File)
Thu, Nov 14, 5:01 AM
Unknown Object (File)
Tue, Nov 5, 3:19 PM
Unknown Object (File)
Oct 22 2024, 3:58 PM
View All Files
Subscribers
dab
emaste
mat
swills
tcberner

Details

Reviewers
mfechner
sunpoet
swills
tota
Group Reviewers
Ruby
portmgr
Summary

Mk/bsd.ruby.mk: Switch from 'USE_RUBY=yes' to 'USES=ruby'

Switch from 'USE_RUBY=yes' to 'USES=ruby'.

Notable changes are.

  • Mk/bsd.ruby.mk is move to Mk/Uses/ruby.mk.
  • 'USE_RUBY=yes' is replaced with 'USES=ruby'.
  • 'USE_RUBY_EXTCONF' is replaced with 'USES=ruby:extconf'.
  • 'USE_RUBY_RDOC' is replaced with 'USES=ruby:rdoc'.
  • 'USE_RUBY_SETUP' is replaces with 'USES=ruby:setup'.
  • 'RUBY_NO_BUILD_DEPENDS' and 'RUBY_NO_RUN_DEPENDS' are replaced with 'USES=ruby:{build,none,run}'.
  • 'RUBY_REQUIRE' isn't used anywhere, so removed.
  • 'USES=gem' now implies 'USES=ruby'.
Test Plan

Test by exp-run

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 47825
Build 44712: arc lint + arc unit

Event Timeline

yasu created this revision.Dec 31 2020, 8:21 AM
Herald added a reviewer: portmgr. · View Herald TranscriptDec 31 2020, 8:22 AM
Herald added subscribers: mat, emaste. · View Herald Transcript
yasu requested review of this revision.Dec 31 2020, 8:22 AM
Harbormaster completed remote builds in B35819: Diff 81409.Dec 31 2020, 8:23 AM
mat added inline comments.Dec 31 2020, 9:25 AM
Mk/Uses/ruby.mk
100–103

What happens if there is a port with:

USES= ruby gem
mat added inline comments.Dec 31 2020, 9:26 AM
Mk/Uses/ruby.mk
100–103

I meant:

USES=ruby:something gem
swills added a subscriber: swills.Jan 5 2021, 10:33 PM
yasu updated this revision to Diff 111751.Oct 13 2022, 4:04 AM
  • Chase Update of ports tree.
  • If both 'gem' and 'ruby' are specified to 'USES', it is now detected as developer's error at check-sanity phase.
Herald added a subscriber: dab. · View Herald TranscriptOct 13 2022, 4:04 AM
Harbormaster completed remote builds in B47825: Diff 111751.Oct 13 2022, 4:04 AM
yasu added a comment.Oct 13 2022, 4:08 AM

@mat Now such case is detected as developer's error at check-sanity phase.

yasu added reviewers: mfechner, sunpoet, swills, tota.Oct 13 2022, 4:12 AM

Add members of ruby team to reviewers.

mfechner added a comment.Oct 15 2022, 6:43 PM

Sry, but I currently do not have hardware and time to test this patch.

tcberner added a subscriber: tcberner.Oct 16 2022, 11:27 AM

Moin moin

Awesome!

I think it would make sense to only include the Mk changes in the review here at first (and maybe move the "adapt port tree") stuff in a separate one, as phabricator is horrible for such big changes.

mfg Tobias

bofh mentioned this in D37925: Move Mk/bsd.ruby.mk to Mk/Uses/ruby.mk..Jan 1 2023, 3:04 PM
bofh mentioned this in R11:18c6e1827669: Mk/**ruby.mk: Switch from USE_RUBY=yes to USES=ruby.Jan 14 2023, 11:09 PM
yasu abandoned this revision.Jan 17 2023, 7:28 AM

With commit 18c6e1827669 'USE_RUBY=yes' is converted to 'USES=ruby'.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 18140980a9845Dec 31 2020, 8:21 AM
Diff 2111751814a13d* Chase Update of ports tree.Oct 13 2022, 4:03 AM
This very large diff affects more than 2,000 files. Use the Changeset List to browse changes.