Page MenuHomeFreeBSD

Move Mk/bsd.ruby.mk to Mk/Uses/ruby.mk.
AbandonedPublic

Authored by yasu on Dec 31 2020, 8:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 6, 9:48 PM
Unknown Object (File)
Fri, Apr 5, 11:08 AM
Unknown Object (File)
Jan 13 2024, 3:11 AM
Unknown Object (File)
Dec 29 2023, 9:33 PM
Unknown Object (File)
Dec 29 2023, 9:33 PM
Unknown Object (File)
Dec 29 2023, 9:33 PM
Unknown Object (File)
Dec 27 2023, 2:40 AM
Unknown Object (File)
Dec 19 2023, 11:52 PM

Details

Reviewers
mfechner
sunpoet
swills
tota
Group Reviewers
Ruby
portmgr
Summary

Mk/bsd.ruby.mk: Switch from 'USE_RUBY=yes' to 'USES=ruby'

Switch from 'USE_RUBY=yes' to 'USES=ruby'.

Notable changes are.

  • Mk/bsd.ruby.mk is move to Mk/Uses/ruby.mk.
  • 'USE_RUBY=yes' is replaced with 'USES=ruby'.
  • 'USE_RUBY_EXTCONF' is replaced with 'USES=ruby:extconf'.
  • 'USE_RUBY_RDOC' is replaced with 'USES=ruby:rdoc'.
  • 'USE_RUBY_SETUP' is replaces with 'USES=ruby:setup'.
  • 'RUBY_NO_BUILD_DEPENDS' and 'RUBY_NO_RUN_DEPENDS' are replaced with 'USES=ruby:{build,none,run}'.
  • 'RUBY_REQUIRE' isn't used anywhere, so removed.
  • 'USES=gem' now implies 'USES=ruby'.
Test Plan

Test by exp-run

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 47825
Build 44712: arc lint + arc unit

Event Timeline

yasu requested review of this revision.Dec 31 2020, 8:22 AM
Mk/Uses/ruby.mk
100–103

What happens if there is a port with:

USES= ruby gem
Mk/Uses/ruby.mk
100–103

I meant:

USES=ruby:something gem
  • Chase Update of ports tree.
  • If both 'gem' and 'ruby' are specified to 'USES', it is now detected as developer's error at check-sanity phase.

@mat Now such case is detected as developer's error at check-sanity phase.

Add members of ruby team to reviewers.

Sry, but I currently do not have hardware and time to test this patch.

Moin moin

Awesome!

I think it would make sense to only include the Mk changes in the review here at first (and maybe move the "adapt port tree") stuff in a separate one, as phabricator is horrible for such big changes.

mfg Tobias

With commit 18c6e1827669 'USE_RUBY=yes' is converted to 'USES=ruby'.