arm64: fix struct l_sigaction_t layout
ClosedPublic
Actions

Authored by mhorne on Dec 3 2020, 4:35 PM.

Details

Reviewers

trasz
andrew
emaste
manu

Commits

rS368458: arm64: fix struct l_sigaction_t layout

Summary

This was likely copied from amd64, but the layout of the struct differs
slightly between these platforms. This fixes spurious `unsupported sigaction
flag 0xXXXXXXXX` messages when executing some Linux binaries on arm64.

Linux struct definition: https://github.com/torvalds/linux/blob/34816d20f173a90389c8a7e641166d8ea9dce70a/include/uapi/asm-generic/signal.h#L104

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Dec 3 2020, 4:35 PM

Herald added a reviewer: manu. · View Herald TranscriptDec 3 2020, 4:35 PM

Herald added a subscriber: imp. · View Herald Transcript

mhorne requested review of this revision.Dec 3 2020, 4:35 PM

Harbormaster completed remote builds in B35168: Diff 80266.Dec 3 2020, 4:35 PM

Yes, seems I just incorrectly copied this from x86.

This revision is now accepted and ready to land.Dec 8 2020, 3:48 PM

Closed by commit rS368458: arm64: fix struct l_sigaction_t layout (authored by mhorne). · Explain WhyDec 8 2020, 6:25 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rS368458: arm64: fix struct l_sigaction_t layout.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

linux/

linux.h

2 lines

Diff 80451

View Options

head/sys/arm64/linux/linux.h

arm64: fix struct l_sigaction_t layoutClosedPublicActions