Page MenuHomeFreeBSD

ossl: split out x86 bits to x86/ossl_cpuid.c
ClosedPublic

Authored by mhorne on Nov 26 2020, 8:26 PM.
Tags
None
Referenced Files
F132479985: D27388.id80037.diff
Fri, Oct 17, 6:49 AM
F132479983: D27388.id80040.diff
Fri, Oct 17, 6:49 AM
F132479982: D27388.id80207.diff
Fri, Oct 17, 6:49 AM
F132479981: D27388.id.diff
Fri, Oct 17, 6:49 AM
F132479980: D27388.id80336.diff
Fri, Oct 17, 6:49 AM
F132430419: D27388.diff
Thu, Oct 16, 9:18 PM
Unknown Object (File)
Tue, Oct 7, 4:38 AM
Unknown Object (File)
Sat, Oct 4, 2:29 AM
Subscribers

Details

Summary

Make room for adding arm64 support to this driver by moving the
x86-specific feature parsing to a separate file.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.

Move common ossl files to conf/files.

In general looks ok. My only wiggle is that right now sys/crypto/openssl/<arch> only contains generated files from OpenSSL (and is shared with the userland libcrypto build via .PATH). The other approach would be to call this new file 'sys/crypto/openssl/ossl_x86.c' and add it to SRCS.amd64 and SRCS.i386 explicitly. I'm not strictly tied to that approach however.

In D27388#613044, @jhb wrote:

In general looks ok. My only wiggle is that right now sys/crypto/openssl/<arch> only contains generated files from OpenSSL (and is shared with the userland libcrypto build via .PATH). The other approach would be to call this new file 'sys/crypto/openssl/ossl_x86.c' and add it to SRCS.amd64 and SRCS.i386 explicitly. I'm not strictly tied to that approach however.

I see, it would be best kept out of that folder then. Naming it ossl_x86.c seems reasonable to me.

Move x86/ossl_cpuid.c to ossl_x86.c.

This revision is now accepted and ready to land.Dec 3 2020, 10:37 PM
This revision was automatically updated to reflect the committed changes.