Page MenuHomeFreeBSD

ossl: split out x86 bits to x86/ossl_cpuid.c
ClosedPublic

Authored by mhorne on Nov 26 2020, 8:26 PM.
Tags
None
Referenced Files
F152554007: D27388.id80336.diff
Wed, Apr 15, 3:54 PM
Unknown Object (File)
Sat, Apr 11, 11:50 AM
Unknown Object (File)
Sun, Mar 29, 12:09 PM
Unknown Object (File)
Wed, Mar 18, 4:21 AM
Unknown Object (File)
Tue, Mar 17, 11:47 AM
Unknown Object (File)
Mar 17 2026, 12:09 AM
Unknown Object (File)
Mar 16 2026, 8:13 PM
Unknown Object (File)
Mar 16 2026, 2:45 AM
Subscribers

Details

Summary

Make room for adding arm64 support to this driver by moving the
x86-specific feature parsing to a separate file.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.

Move common ossl files to conf/files.

In general looks ok. My only wiggle is that right now sys/crypto/openssl/<arch> only contains generated files from OpenSSL (and is shared with the userland libcrypto build via .PATH). The other approach would be to call this new file 'sys/crypto/openssl/ossl_x86.c' and add it to SRCS.amd64 and SRCS.i386 explicitly. I'm not strictly tied to that approach however.

In D27388#613044, @jhb wrote:

In general looks ok. My only wiggle is that right now sys/crypto/openssl/<arch> only contains generated files from OpenSSL (and is shared with the userland libcrypto build via .PATH). The other approach would be to call this new file 'sys/crypto/openssl/ossl_x86.c' and add it to SRCS.amd64 and SRCS.i386 explicitly. I'm not strictly tied to that approach however.

I see, it would be best kept out of that folder then. Naming it ossl_x86.c seems reasonable to me.

Move x86/ossl_cpuid.c to ossl_x86.c.

This revision is now accepted and ready to land.Dec 3 2020, 10:37 PM
This revision was automatically updated to reflect the committed changes.