Make room for adding arm64 support to this driver by moving the
x86-specific feature parsing to a separate file.
Details
Details
- Reviewers
jhb jmg - Commits
- rS368349: ossl: split out x86 bits to x86/ossl_cpuid.c
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
In general looks ok. My only wiggle is that right now sys/crypto/openssl/<arch> only contains generated files from OpenSSL (and is shared with the userland libcrypto build via .PATH). The other approach would be to call this new file 'sys/crypto/openssl/ossl_x86.c' and add it to SRCS.amd64 and SRCS.i386 explicitly. I'm not strictly tied to that approach however.
Comment Actions
I see, it would be best kept out of that folder then. Naming it ossl_x86.c seems reasonable to me.