Page MenuHomeFreeBSD

mips: Fix sub-word atomics implementation
ClosedPublic

Authored by jrtc27 on Nov 23 2020, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 11, 7:06 PM
Unknown Object (File)
Dec 13 2024, 2:24 PM
Unknown Object (File)
Sep 17 2024, 1:37 PM
Unknown Object (File)
Aug 9 2024, 5:50 AM
Unknown Object (File)
Aug 9 2024, 12:27 AM
Unknown Object (File)
Jul 7 2024, 10:33 AM
Unknown Object (File)
Jul 3 2024, 3:49 PM
Unknown Object (File)
May 23 2024, 10:15 AM
Subscribers
None

Details

Summary

These aligned the address but then always used the least significant
bits of the value in memory, which is the wrong half 50% of the time for
16-bit atomics and the wrong quarter 75% of the time for 8-bit atomics.
These bugs were all present in r178172, the commit that added the mips
port, and have remained for its entire existence to date.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34987
Build 31980: arc lint + arc unit

Event Timeline

jrtc27 created this revision.
This revision is now accepted and ready to land.Nov 24 2020, 11:43 PM
This revision was automatically updated to reflect the committed changes.