Page MenuHomeFreeBSD

mips: Fix sub-word atomics implementation
ClosedPublic

Authored by jrtc27 on Nov 23 2020, 7:34 PM.
Tags
None
Referenced Files
F132618620: D27343.id79914.diff
Sat, Oct 18, 11:51 AM
Unknown Object (File)
Wed, Oct 15, 8:06 AM
Unknown Object (File)
Thu, Sep 25, 1:02 PM
Unknown Object (File)
Tue, Sep 23, 6:44 PM
Unknown Object (File)
Sun, Sep 21, 12:08 AM
Unknown Object (File)
Sep 10 2025, 3:12 AM
Unknown Object (File)
Aug 30 2025, 7:21 AM
Unknown Object (File)
Aug 25 2025, 9:37 PM
Subscribers
None

Details

Summary

These aligned the address but then always used the least significant
bits of the value in memory, which is the wrong half 50% of the time for
16-bit atomics and the wrong quarter 75% of the time for 8-bit atomics.
These bugs were all present in r178172, the commit that added the mips
port, and have remained for its entire existence to date.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrtc27 created this revision.
This revision is now accepted and ready to land.Nov 24 2020, 11:43 PM
This revision was automatically updated to reflect the committed changes.