Add pw_mkdb2() to libutil

[bapt]

Summary

Add a pw_mkdb2 function that allows to pass the endianness for the
database to generate

[• ian]

Looks good to me, modulo the one typo that needs fixing.

lib/libutil/pw_util.c

249 ↗

(On Diff #5925)

s/b PWDB_NATIVE

[wblock]

head/lib/libutil/pw_util.3

237

Remove "function":

regenerates the password database by running

248

These sentences should be capitalized:

The database...

250

Capitalize.

252

Capitalize.

[bapt]

Capitalization has been committed

[bapt]

head/lib/libutil/pw_util.3

237

All previous functions have: The <functionname> function ...
So either I should remove "The" and "function" everywhere or I add the missing "The" here. I have no strong opinion here, what about you? :)

[wblock]

head/lib/libutil/pw_util.3

237

"The blahblah function" is only needed if it is unclear whether blahblah is a function. Usually it is shorter and simpler to just use the name.

I restricted my review to changed lines, but most of the other uses are redundant also.

250

Oops, missed the first time: "little-endian" should not be capitalized. Also, passive->active: s/will be/is/. This should probably be more specific, too:
The database is generated in little-endian byte order.

(Just winging it, you might have a better way to say this.)

252

The database is generated in big-endian byte order.

[• ian]

head/lib/libutil/pw_util.3

250

"is generated" is still passive voice. I don't have the problem with passive voice that most people seem to, but if you want to go active-voice you need an action verb, not a state-of-being verb. E.g., "Generate the database in little-endian byte order."

[wblock]

head/lib/libutil/pw_util.3

250

You're right, it's easy to see one problem but miss others. New version:

Generate the database in little-endian byte order.

252

As above:

Generate the database in big-endian byte order.