- At revision r247852 @mm accidentally we forgot to print out the obj too.
- Fix some void function that don't really need to return.
- Also for some global variables, declare it as static.
Please note that the two comments inline, I think they are wrong and should be reverted. The rest part of the proposed patch looks good to me.
|182 ↗||(On Diff #5906)|
This is wrong. usage() is supposed to be an exit point.
|201 ↗||(On Diff #5906)|
This is also wrong, similar to usage() fatal is supposed to be a __dead exit.
Adding Matt to reviewer so he gets notification. I think we should upstream most of the changes to Illumos -- Marcelo, can you create an Illumos ticket for this? I can create a review request there too but since you wrote the patch it's better that you get involved too :)
|96 ↗||(On Diff #6013)|
These changes should be upstreamed to Illumos.
|1492 ↗||(On Diff #6013)|
This should be upstreamed to Illumos.
|1494 ↗||(On Diff #6013)|
I'm not sure about the style here -- I think if I was the author I would have a blank line on after line 1490, but it's not clear if it also matches Illumos code style.
|1500 ↗||(On Diff #6013)|
This should be upstreamed too.