Page MenuHomeFreeBSD

[POWERPC] msun: fix incorrect flag in fesetexceptflag
ClosedPublic

Authored by alfredo on Nov 12 2020, 10:29 PM.
Referenced Files
F106055402: D27201.diff
Tue, Dec 24, 3:12 PM
Unknown Object (File)
Fri, Dec 20, 6:44 PM
Unknown Object (File)
Sat, Dec 7, 6:50 PM
Unknown Object (File)
Nov 13 2024, 12:39 AM
Unknown Object (File)
Oct 3 2024, 8:02 AM
Unknown Object (File)
Sep 24 2024, 4:05 PM
Unknown Object (File)
Sep 20 2024, 7:55 AM
Unknown Object (File)
Sep 16 2024, 4:47 PM
Subscribers

Details

Summary

Fixes incorrect mask being used when FE_INVALID bit is wanted by user.

The problem was noticed thanks lib msun fenv tests, that was failing on test 3.

*fenv test still crashes on test 6, this will be addressed on another review

Test Plan

Tested on powerpc64. Without the patch When running fenv_test, it should print "ok 3 - fenv". It will crash with assert after "ok 2 - fenv" when unpatched.

$ ./fenv_test
1..8
ok 1 - fenv
ok 2 - fenv
ok 3 - fenv
ok 4 - fenv
ok 5 - fenv
Assertion failed: (fetestexcept(FE_ALL_EXCEPT) == excepts), function test_fegsetenv, file /usr/home/alfredo/src/freebsd/lib/msun/tests/fenv_test.c, line 376.
Abort trap (core dumped)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable