[PowerPC64LE] Radix fixes for LE
ClosedPublic
Actions

Authored by bdragon on Nov 11 2020, 6:41 PM.

Details

Reviewers

pkubaj
luporl
jhibbits

Group Reviewers

PowerPC

Commits

rS367644: [PowerPC64LE] Radix MMU fixes for LE.

Summary

There were many, many endianness fixes needed for Radix MMU. Every interaction with PTE memory was wrong.

With these changes, I can successfully boot with radix enabled on POWER9 hw.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bdragon created this revision.Nov 11 2020, 6:41 PM

Herald added subscribers: alfredo, imp. · View Herald TranscriptNov 11 2020, 6:41 PM

bdragon requested review of this revision.Nov 11 2020, 6:41 PM

bdragon added inline comments.Nov 11 2020, 6:59 PM

sys/powerpc/aim/mmu_radix.c
1823	This bit is a bugfix I noticed while doing readthroughs. I will probably commit it separately.

Looks fine to me

This revision is now accepted and ready to land.Nov 11 2020, 10:48 PM

Wow, that's really a lot of endianness fixes, nice job!

It looks good to me.

sys/powerpc/aim/mmu_radix.c
2638–2661	This part is a fix for both LE and BE, right? It could be moved to another diff, but I'm fine with leaving it as part of this one too.

Closed by commit rS367644: [PowerPC64LE] Radix MMU fixes for LE. (authored by bdragon). · Explain WhyNov 13 2020, 4:56 PM

This revision was automatically updated to reflect the committed changes.

bdragon added a commit: rS367644: [PowerPC64LE] Radix MMU fixes for LE..

Revision Contents
Changeset List

Path

Size

sys/

powerpc/

aim/

mmu_radix.c

421 lines

Diff 79437

View Options

sys/powerpc/aim/mmu_radix.c

[PowerPC64LE] Radix fixes for LEClosedPublicActions