Page MenuHomeFreeBSD

[PowerPC] Don't overwrite vm.pmap sysctl node
ClosedPublic

Authored by luporl on Nov 9 2020, 8:31 PM.
Referenced Files
Unknown Object (File)
Sun, Nov 24, 11:59 PM
Unknown Object (File)
Sun, Nov 24, 3:32 AM
Unknown Object (File)
Fri, Nov 15, 2:04 PM
Unknown Object (File)
Thu, Nov 14, 6:11 PM
Unknown Object (File)
Oct 18 2024, 2:18 AM
Unknown Object (File)
Oct 5 2024, 8:57 PM
Unknown Object (File)
Oct 4 2024, 8:43 PM
Unknown Object (File)
Oct 4 2024, 11:30 AM
Subscribers

Details

Summary

After r367417, both mmu_oea64 and mmu_radix were defining the vm.pmap
sysctl node, resulting in the later definition hiding the properties of
the previous one. Avoid this issue by defining vm.pmap in a common
source file and declaring it where needed.

This change also standardizes the tunable name used to enable superpages.

Test Plan

Checked that all child nodes and properties of vm.pmap can be seen and that the value of superpages_enabled is correct, with the following boot arguments:

  • <none>
  • vm.pmap.superpages_enabled=1
  • radix_mmu=1
  • radix_mmu=1 vm.pmap.superpages_enabled=0

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34714
Build 31772: arc lint + arc unit

Event Timeline

luporl requested review of this revision.Nov 9 2020, 8:31 PM
sys/powerpc/powerpc/pmap_dispatch.c
86

Since superpages still have issues in Radix, it's probably better to just disable it by default for now.

Looks good to me, and works nicely.

And yeah, I think we should turn off radix superpages for the moment, there are still some weird interactions between it and stuff like the python3 jit.

This revision is now accepted and ready to land.Nov 15 2020, 3:07 AM

Leave superpages disabled by default

This revision now requires review to proceed.Nov 16 2020, 4:48 PM
This revision is now accepted and ready to land.Nov 16 2020, 8:44 PM
This revision was automatically updated to reflect the committed changes.