Page MenuHomeFreeBSD

sysvshm: pass relavent uap members as arguments
ClosedPublic

Authored by brooks on Nov 3 2020, 5:44 PM.
Tags
None
Referenced Files
F110348825: D27077.diff
Mon, Feb 17, 4:18 AM
Unknown Object (File)
Thu, Feb 13, 2:43 PM
Unknown Object (File)
Thu, Jan 30, 10:38 AM
Unknown Object (File)
Jan 17 2025, 6:40 AM
Unknown Object (File)
Jan 17 2025, 12:03 AM
Unknown Object (File)
Jan 16 2025, 1:36 PM
Unknown Object (File)
Jan 11 2025, 1:11 AM
Unknown Object (File)
Jan 10 2025, 7:39 AM
Subscribers

Details

Summary

Alter shmget_allocate_segment and shmget_existing to take the values
they want from struct shmget_args rather than passing the struct
around. In general, uap structures should only be the interface to
sys_<foo> functions.

This makes on small functional change and records the allocated space
rather than the requested space. If this turns out to be a problem (e.g.
if software tries to find undersized segments by exact size rather than
using keys), we can correct that easily.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks requested review of this revision.Nov 3 2020, 5:44 PM
brooks created this revision.
kib added inline comments.
sys/kern/sysv_shm.c
114 ↗(On Diff #79134)

Since you are modifying all lines, move declarations to the block below, together with other function's declarations.

This revision is now accepted and ready to land.Nov 3 2020, 6:37 PM
This revision was automatically updated to reflect the committed changes.