Page MenuHomeFreeBSD

sysvshm: pass relavent uap members as arguments
ClosedPublic

Authored by brooks on Nov 3 2020, 5:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 4:38 AM
Unknown Object (File)
Sun, Apr 7, 10:57 PM
Unknown Object (File)
Jan 30 2024, 4:15 PM
Unknown Object (File)
Jan 4 2024, 4:23 PM
Unknown Object (File)
Nov 13 2023, 12:39 AM
Unknown Object (File)
Oct 7 2023, 6:59 PM
Unknown Object (File)
Oct 3 2023, 8:03 PM
Unknown Object (File)
Sep 1 2023, 6:56 PM
Subscribers

Details

Summary

Alter shmget_allocate_segment and shmget_existing to take the values
they want from struct shmget_args rather than passing the struct
around. In general, uap structures should only be the interface to
sys_<foo> functions.

This makes on small functional change and records the allocated space
rather than the requested space. If this turns out to be a problem (e.g.
if software tries to find undersized segments by exact size rather than
using keys), we can correct that easily.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34602
Build 31691: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Nov 3 2020, 5:44 PM
brooks created this revision.
kib added inline comments.
sys/kern/sysv_shm.c
114

Since you are modifying all lines, move declarations to the block below, together with other function's declarations.

This revision is now accepted and ready to land.Nov 3 2020, 6:37 PM
This revision was automatically updated to reflect the committed changes.