if_media.c SIOCGMEDIAX handler: improve loop

[kib]

Summary

Stop advancing counter past the current iteration number at the start of iteration. This removes the need of subtracting one when calculating index for copyout, and arguably fixes off-by-one reporting of copied out elements when copyout failed.

Sponsored by: Mellanox Technologies / NVidia Networking

[• hselasky]

sys/net/if_media.c

312

I think this if should just read:

if (ep == NULL)

--HPS

[• hselasky]

sys/net/if_media.c

312

if (ep == NULL && i > ifm->ifm_count)

[kib]

sys/net/if_media.c

312

Do you suggest that this would make any functional change ? I believe it is not, and for me using counters for both sides of 'and' is somewhat cleaner.

[• hselasky]

sys/net/if_media.c

312

No, it doesn't make any functional change. It just took some time to understand the code. Maybe that if (error != 0) break, should be a goto, because the if (error == 0) is then a NOP. Anyways, I've also accepted the current version.