Page MenuHomeFreeBSD

Split logic to create new sessions into a separate function.
ClosedPublic

Authored by jhb on Nov 2 2020, 8:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 4:52 PM
Unknown Object (File)
Sun, Sep 28, 1:38 PM
Unknown Object (File)
Sat, Sep 27, 6:38 AM
Unknown Object (File)
Fri, Sep 26, 4:04 PM
Unknown Object (File)
Thu, Sep 18, 3:50 AM
Unknown Object (File)
Sep 12 2025, 6:15 AM
Unknown Object (File)
Aug 30 2025, 8:24 AM
Unknown Object (File)
Aug 29 2025, 12:12 PM
Subscribers

Details

Summary

This simplifies cryptof_ioctl as it now a wrapper around functions that
contain the bulk of the per-ioctl logic.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Nov 2 2020, 8:50 PM
jhb created this revision.
markj added inline comments.
sys/opencrypto/cryptodev.c
431 ↗(On Diff #79098)

At times I've wanted a CRYPTO_NULL or so for this case.

716 ↗(On Diff #79098)

Is it worth keeping ARGSUSED and similar linter annotations? I usually delete them when I come across them.

This revision is now accepted and ready to land.Nov 2 2020, 10:09 PM
sys/opencrypto/cryptodev.c
431 ↗(On Diff #79098)

Yeah. Unfortunately, CRYPTO_NULL_HMAC and CRYPTO_NULL_CBC get in the way. Really we should kill those though. I feel like IPsec, etc. should handle "null" ciphers explicitly. NULL_HMAC is especially egregious as it writes out a 96-bit zero hash that is IPsec-specific.

716 ↗(On Diff #79098)

Hmm, probably not. I'll kill them in things I move.

jhb marked an inline comment as done.Nov 6 2020, 12:15 AM

Trimmed ARGSUSED in the followup commit that moves the function.