Differential D27068

Split logic to create new sessions into a separate function.
ClosedPublic
Actions

Authored by jhb on Nov 2 2020, 8:50 PM.

Tags

None

Referenced Files

	F153255445: D27068.diff
	Mon, Apr 20, 2:29 AM

	Unknown Object (File)
	Sun, Apr 19, 2:32 AM

	Unknown Object (File)
	Sat, Apr 18, 10:09 AM

	Unknown Object (File)
	Sun, Apr 12, 7:17 AM

	Unknown Object (File)
	Sun, Apr 5, 1:26 PM

	Unknown Object (File)
	Fri, Apr 3, 4:53 PM

	Unknown Object (File)
	Thu, Mar 26, 8:50 PM

	Unknown Object (File)
	Wed, Mar 25, 2:14 PM

Subscribers

Details

Reviewers

markj
jmg

Commits

rS367409: Split logic to create new sessions into a separate function.

Summary

This simplifies cryptof_ioctl as it now a wrapper around functions that
contain the bulk of the per-ioctl logic.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Nov 2 2020, 8:50 PM

jhb created this revision.

Harbormaster completed remote builds in B34583: Diff 79098.Nov 2 2020, 8:50 PM

jhb added a parent revision: D27066: Style fixes for function prototypes and definitions..Nov 2 2020, 8:59 PM

jhb added a child revision: D27069: Move cryptof_ioctl() below the routines it calls..

jhb added a child revision: D27070: Group session management routines together before first use..Nov 2 2020, 9:03 PM

markj accepted this revision.Nov 2 2020, 10:09 PM

markj added inline comments.

sys/opencrypto/cryptodev.c
431 ↗	(On Diff #79098)	At times I've wanted a CRYPTO_NULL or so for this case.
716 ↗	(On Diff #79098)	Is it worth keeping ARGSUSED and similar linter annotations? I usually delete them when I come across them.

This revision is now accepted and ready to land.Nov 2 2020, 10:09 PM

jhb added inline comments.Nov 5 2020, 11:46 PM

sys/opencrypto/cryptodev.c
431 ↗	(On Diff #79098)	Yeah. Unfortunately, CRYPTO_NULL_HMAC and CRYPTO_NULL_CBC get in the way. Really we should kill those though. I feel like IPsec, etc. should handle "null" ciphers explicitly. NULL_HMAC is especially egregious as it writes out a 96-bit zero hash that is IPsec-specific.
716 ↗	(On Diff #79098)	Hmm, probably not. I'll kill them in things I move.

Closed by commit rS367409: Split logic to create new sessions into a separate function. (authored by jhb). · Explain WhyNov 6 2020, 12:11 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS367409: Split logic to create new sessions into a separate function..

Herald added a reviewer: jmg. · View Herald TranscriptNov 6 2020, 12:11 AM

Herald added a subscriber: imp. · View Herald Transcript

Trimmed ARGSUSED in the followup commit that moves the function.

Revision Contents
Changeset List

Path

Size

head/

sys/

opencrypto/

603 lines

Diff 79244

head/sys/opencrypto/cryptodev.c

Loading...