Use public interfaces to manage the nested rate limit send tag.

[jhb]

Summary

Each TLS send tag in mlx5 contains a nested rate limit send tag.
Previously, the driver was calling internal functions to manage the
nested tag. Calling free methods directly instead of m_snd_tag_rele()
leaked send tag references and references on the ifp. Changes to use
the ifp methods for the nested tag for other methods are more cosmetic
but do simplify the code.

Test Plan

• Drew tested a smaller version of this patch (mostly the m_snd_tag_rele bits)

[• hselasky]

Looks good!

[• hselasky]

sys/dev/mlx5/mlx5_en/mlx5_en_hw_tls.c

450

you probably can also remove all instances of && defined(IF_SND_TAG_TYPE_TLS_RATE_LIMIT)

[jhb]

sys/dev/mlx5/mlx5_en/mlx5_en_hw_tls.c

450

True. I will create a review to do that as a separate commit in a bit.