iommu_unmap_msi() added
ClosedPublic
Actions

Authored by br on Oct 22 2020, 5:04 PM.

Details

Reviewers

andrew
kib
manu

Commits

rS367016: o Add iommu de-initialization method for MSI interface.

Summary

Add iommu de-initialization method for MSI.

This is needed to free up all the entries in GAS tree before iommu domain teardown and pmap release

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

br created this revision.Oct 22 2020, 5:04 PM

Herald added a reviewer: manu. · View Herald TranscriptOct 22 2020, 5:04 PM

Herald added a subscriber: emaste. · View Herald Transcript

br requested review of this revision.Oct 22 2020, 5:04 PM

kib added inline comments.Oct 23 2020, 5:06 PM

sys/arm64/arm64/gicv3_its.c
1469 ↗	(On Diff #78605)	This blank line is useless.
sys/dev/iommu/iommu_gas.c
738 ↗	(On Diff #78605)	I think there should be a check entry != NULL and early return. Or assert that entry != NULL.

o Check if entry is not NULL, otherwise return early
o Remove gicv3_its.c changes from this diff. They are moved to https://reviews.freebsd.org/D26878

kib accepted this revision.Oct 23 2020, 10:43 PM

This revision is now accepted and ready to land.Oct 23 2020, 10:43 PM

kib added inline comments.Oct 23 2020, 10:43 PM