Page MenuHomeFreeBSD

zfs: fix panic due to tqid overflow
ClosedPublic

Authored by mjg on Oct 13 2020, 12:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 10, 8:33 AM
Unknown Object (File)
Thu, Sep 10, 5:57 AM
Unknown Object (File)
Wed, Sep 9, 7:02 PM
Unknown Object (File)
Tue, Sep 8, 1:25 PM
Unknown Object (File)
Sun, Sep 6, 10:59 AM
Unknown Object (File)
Sun, Sep 6, 7:40 AM
Unknown Object (File)
Sun, Sep 6, 2:10 AM
Unknown Object (File)
Sat, Sep 5, 7:41 PM
Subscribers

Details

Summary

The 32-bit counter eventually wraps to 0 which is a sentinel for invalid id.

Make it 64-bit on LP64 platforms and 0-check otherwise.

Note: Linux counterpart uses id stored per queue instead of a global.
I did not check going that way is feasible with the goal being the minimal fix doing the job.

Once this is sorted out I'll post a review on github.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mjg requested review of this revision.Oct 13 2020, 12:55 PM

Makes sense to me. I just hope that situation of ID duplicate due to wraparound it too unlikely on 32-bit even considering taskq_dispatch_delay(). Though not sure who really used any 32bit platforms recently, even considering recent i386 KVA increase to 4GB.

This revision is now accepted and ready to land.Oct 13 2020, 4:04 PM
This revision was automatically updated to reflect the committed changes.