Page MenuHomeFreeBSD

Don't permit DRM buffer mappings to be upgraded to executable.
ClosedPublic

Authored by jhb on Oct 6 2020, 5:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 7:29 PM
Unknown Object (File)
Mon, Oct 6, 3:19 PM
Unknown Object (File)
Thu, Oct 2, 3:52 PM
Unknown Object (File)
Tue, Sep 30, 8:04 PM
Unknown Object (File)
Sep 13 2025, 7:11 AM
Unknown Object (File)
Sep 9 2025, 7:14 AM
Unknown Object (File)
Aug 16 2025, 10:14 PM
Unknown Object (File)
Aug 16 2025, 4:05 PM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Oct 6 2020, 5:30 PM
jhb created this revision.

I know this is stale code, and @manu is just on the cc in case there is similar code in the out-of-tree drm bits.

In D26697#594863, @jhb wrote:

I know this is stale code, and @manu is just on the cc in case there is similar code in the out-of-tree drm bits.

Thanks, the same code is still there even if drm_bufs are not used most of the time iirc.
I'll patch drm-kmod anyway.

Note that it's not stale code, it's still used for Tegra drm driver.

kib added inline comments.
sys/dev/drm2/drm_bufs.c
1638 ↗(On Diff #77946)

Then use VM_PROT_RW for prot as well.

This revision is now accepted and ready to land.Oct 6 2020, 5:40 PM
jhb marked an inline comment as done.Oct 6 2020, 6:10 PM