Don't permit DRM buffer mappings to be upgraded to executable.
ClosedPublic
Actions

Authored by jhb on Oct 6 2020, 5:30 PM.

Details

Reviewers

kib
mmel

Commits

rS366494: Don't permit DRM buffer mappings to be upgraded to executable.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Oct 6 2020, 5:30 PM

jhb created this revision.

Harbormaster completed remote builds in B34022: Diff 77946.Oct 6 2020, 5:30 PM

I know this is stale code, and @manu is just on the cc in case there is similar code in the out-of-tree drm bits.

In D26697#594863, @jhb wrote:

I know this is stale code, and @manu is just on the cc in case there is similar code in the out-of-tree drm bits.

Thanks, the same code is still there even if drm_bufs are not used most of the time iirc.
I'll patch drm-kmod anyway.

Note that it's not stale code, it's still used for Tegra drm driver.

kib accepted this revision.Oct 6 2020, 5:40 PM

kib added inline comments.

sys/dev/drm2/drm_bufs.c
1638 ↗	(On Diff #77946)	Then use VM_PROT_RW for prot as well.

This revision is now accepted and ready to land.Oct 6 2020, 5:40 PM

jhb marked an inline comment as done.Oct 6 2020, 6:10 PM

Closed by commit rS366494: Don't permit DRM buffer mappings to be upgraded to executable. (authored by jhb). · Explain WhyOct 6 2020, 6:13 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS366494: Don't permit DRM buffer mappings to be upgraded to executable..

Herald added a subscriber: imp. · View Herald TranscriptOct 6 2020, 6:13 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

drm2/

drm_bufs.c

10 lines

Diff 77950

View Options

head/sys/dev/drm2/drm_bufs.c

Don't permit DRM buffer mappings to be upgraded to executable.ClosedPublicActions