Do not allow to use O_BENEATH as an oracle.
ClosedPublic
Actions

Authored by kib on Oct 6 2020, 3:48 PM.

Tags

None

Referenced Files

	F151171333: D26695.id77943.diff
	Mon, Apr 6, 2:04 PM

	Unknown Object (File)
	Sun, Mar 29, 1:10 PM

	Unknown Object (File)
	Fri, Mar 27, 10:19 AM

	Unknown Object (File)
	Fri, Mar 27, 9:59 AM

	Unknown Object (File)
	Wed, Mar 25, 12:44 AM

	Unknown Object (File)
	Wed, Mar 18, 3:37 AM

	Unknown Object (File)
	Sat, Mar 14, 10:51 PM

	Unknown Object (File)
	Mar 3 2026, 3:49 AM

View All Files

Subscribers

imp

lwhsu

Details

Reviewers

markj
emaste
ngie

Commits

rS366549: Do not allow to use O_BENEATH as an oracle.

Summary

Specifically, if lookup() returned any error and the topping directory was not latched, give ENOTCAPABLE a priority over the lookup() error.

PR: 249960

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Oct 6 2020, 3:48 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 6 2020, 3:48 PM

kib requested review of this revision.Oct 6 2020, 3:48 PM

Harbormaster completed remote builds in B34019: Diff 77943.Oct 6 2020, 3:48 PM

emaste added inline comments.Oct 6 2020, 4:12 PM

sys/kern/vfs_lookup.c
600 ↗	(On Diff #77943)	extra line?

Empty comment line.

Harbormaster completed remote builds in B34020: Diff 77944.Oct 6 2020, 4:24 PM

ngie accepted this revision.Oct 6 2020, 7:16 PM

This revision is now accepted and ready to land.Oct 6 2020, 7:16 PM

emaste accepted this revision.Oct 8 2020, 6:03 PM

Closed by commit rS366549: Do not allow to use O_BENEATH as an oracle. (authored by kib). · Explain WhyOct 8 2020, 10:31 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS366549: Do not allow to use O_BENEATH as an oracle..

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

vfs_lookup.c

11 lines

Diff 78028

View Options

head/sys/kern/vfs_lookup.c

Do not allow to use O_BENEATH as an oracle.ClosedPublicActions