Page MenuHomeFreeBSD
Differential D26695

Do not allow to use O_BENEATH as an oracle.
ClosedPublic
Actions

Authored by kib on Oct 6 2020, 3:48 PM.
Tags
None
Referenced Files
F132464114: D26695.diff
Fri, Oct 17, 3:52 AM
Unknown Object (File)
Tue, Oct 14, 11:42 AM
Unknown Object (File)
Wed, Sep 24, 2:04 PM
Unknown Object (File)
Wed, Sep 24, 2:35 AM
Unknown Object (File)
Wed, Sep 17, 11:40 AM
Unknown Object (File)
Sep 17 2025, 6:46 AM
Unknown Object (File)
Sep 17 2025, 4:40 AM
Unknown Object (File)
Sep 15 2025, 12:42 AM
View All Files
Subscribers
imp
lwhsu

Details

Reviewers
markj
emaste
ngie
Commits
rS366549: Do not allow to use O_BENEATH as an oracle.
Summary

Specifically, if lookup() returned any error and the topping directory was not latched, give ENOTCAPABLE a priority over the lookup() error.

PR: 249960

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Oct 6 2020, 3:48 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 6 2020, 3:48 PM
kib requested review of this revision.Oct 6 2020, 3:48 PM
Harbormaster completed remote builds in B34019: Diff 77943.Oct 6 2020, 3:48 PM
emaste added inline comments.Oct 6 2020, 4:12 PM
sys/kern/vfs_lookup.c
600 ↗(On Diff #77943)

extra line?

kib updated this revision to Diff 77944.Oct 6 2020, 4:24 PM
kib marked an inline comment as done.

Empty comment line.

Harbormaster completed remote builds in B34020: Diff 77944.Oct 6 2020, 4:24 PM
ngie accepted this revision.Oct 6 2020, 7:16 PM
This revision is now accepted and ready to land.Oct 6 2020, 7:16 PM
emaste accepted this revision.Oct 8 2020, 6:03 PM
Closed by commit rS366549: Do not allow to use O_BENEATH as an oracle. (authored by kib). · Explain WhyOct 8 2020, 10:31 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rS366549: Do not allow to use O_BENEATH as an oracle..

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
11 lines

Diff 78028

View Options

head/sys/kern/vfs_lookup.c

Loading...