Page MenuHomeFreeBSD

Use unlocked page lookup for inmem() to avoid object lock contention
ClosedPublic

Authored by mlaier on Oct 3 2020, 6:57 PM.

Details

Summary

Let's try this again:

  • make a vm_page_lookup_unlocked
  • really bool-ify
  • while here, export inmem alongside incore (we have a local diff for this)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mlaier requested review of this revision.Oct 3 2020, 6:57 PM
mlaier created this revision.

Moving the tinc calculation back up - needed for valid range

markj added inline comments.
sys/vm/vm_page.c
1701 ↗(On Diff #77910)

I think this deserves a comment to match the others. e.g., the description for vm_page_lookup(), plus, "The page may be no longer be present in the object at the time that this function returns."

This revision is now accepted and ready to land.Oct 6 2020, 12:47 PM

Add comment per markj's request.

This revision now requires review to proceed.Oct 8 2020, 10:14 PM
This revision is now accepted and ready to land.Oct 8 2020, 10:48 PM