Page MenuHomeFreeBSD
Differential D26423

Integrate 4.4BSD-Lite2 changes to IOC_* definitions
ClosedPublic
Actions

Authored by imp on Sep 14 2020, 5:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 14 2024, 5:11 AM
Unknown Object (File)
Dec 23 2023, 2:30 AM
Unknown Object (File)
Dec 14 2023, 1:46 AM
Unknown Object (File)
Nov 25 2023, 4:53 AM
Unknown Object (File)
Nov 23 2023, 1:03 AM
Unknown Object (File)
Nov 23 2023, 1:01 AM
Unknown Object (File)
Nov 23 2023, 12:40 AM
Unknown Object (File)
Nov 23 2023, 12:26 AM
View All 24 Files
Subscribers
delphij
emaste
jhb
kib
pi

Details

Reviewers
kib
Commits
rS367189: Integrate 4.4BSD-Lite2 changes to IOC_* definitions
Summary

Bring in the long-overdue 4.4BSD-Lite2 rev 8.3 by cgd of
sys/ioccom.h. This uses UL suffix for the IOC_* constants so they
don't sign extend. Also bring in the handy diagram from NetBSD's
version of this file. This alters the 4.4BSD-Lite2 code slightly
in a way that's semantically the same but more compact.

This should stop the warnings from Chrome for bogus sign extension.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Sep 14 2020, 5:43 PM
imp created this revision.
Harbormaster completed remote builds in B33546: Diff 77016.Sep 14 2020, 5:43 PM
kib added a subscriber: kib.Sep 14 2020, 6:25 PM
kib added inline comments.
sys/sys/ioccom.h
56 ↗(On Diff #77016)

Why not write it as 0x20000000UL ? More, I think that 0x20000000U would be enough.

pi added a subscriber: pi.Sep 14 2020, 6:47 PM
jhb added a subscriber: jhb.Sep 14 2020, 8:23 PM
jhb added inline comments.
sys/sys/ioccom.h
56 ↗(On Diff #77016)

This would also avoid the need to move the comments around and make for a smaller diff in general.

delphij added a subscriber: delphij.Sep 15 2020, 4:34 AM
emaste added a subscriber: emaste.Sep 24 2020, 12:23 PM
imp updated this revision to Diff 78872.Oct 28 2020, 11:32 PM

Used UL to ensure this is always a long per 4.4BSD-lite2. U might be
enough, but this is semantically the same as $OTHER BSD where that is
not.

Harbormaster completed remote builds in B34454: Diff 78872.Oct 28 2020, 11:32 PM
imp marked 2 inline comments as done.Oct 28 2020, 11:32 PM
imp edited the summary of this revision. (Show Details)
kib accepted this revision.Oct 29 2020, 11:48 AM
This revision is now accepted and ready to land.Oct 29 2020, 11:48 AM
Closed by commit rS367189: Integrate 4.4BSD-Lite2 changes to IOC_* definitions (authored by imp). · Explain WhyOct 30 2020, 10:00 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rS367189: Integrate 4.4BSD-Lite2 changes to IOC_* definitions.

Revision Contents
Changeset List

PathSize
head/
sys/
sys/
18 lines

Diff 78994

View Options

head/sys/sys/ioccom.h

Loading...