Page MenuHomeFreeBSD

Integrate 4.4BSD-Lite2 changes to IOC_* definitions
Needs ReviewPublic

Authored by imp on Mon, Sep 14, 5:43 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Bring in the long-overdue 4.4BSD-Lite2 rev 8.3 by cgd of
sys/ioccom.h. This casts the IOC_* constants to unsigned long so they
don't sign extend. Also bring in the handy diagram from NetBSD's
version of this file.

This should stop the warnings from Chrome for bogus sign extension.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 33546
Build 30803: arc lint + arc unit

Event Timeline

imp requested review of this revision.Mon, Sep 14, 5:43 PM
imp created this revision.
kib added a subscriber: kib.Mon, Sep 14, 6:25 PM
kib added inline comments.
sys/sys/ioccom.h
56

Why not write it as 0x20000000UL ? More, I think that 0x20000000U would be enough.

pi added a subscriber: pi.Mon, Sep 14, 6:47 PM
jhb added a subscriber: jhb.Mon, Sep 14, 8:23 PM
jhb added inline comments.
sys/sys/ioccom.h
56

This would also avoid the need to move the comments around and make for a smaller diff in general.

emaste added a subscriber: emaste.Thu, Sep 24, 12:23 PM